Delete an observation

This commit is contained in:
Matthew Dillon 2014-11-21 18:58:07 -09:00
parent b90da728fe
commit 952224e2df
9 changed files with 141 additions and 0 deletions

View file

@ -51,6 +51,7 @@ func Handler() *mux.Router {
m.Get(router.CreateObservation).Handler(handler(serveCreateObservation))
m.Get(router.Observations).Handler(handler(serveObservationList))
m.Get(router.UpdateObservation).Handler(handler(serveUpdateObservation))
m.Get(router.DeleteObservation).Handler(handler(serveDeleteObservation))
return m
}

View file

@ -76,3 +76,17 @@ func serveUpdateObservation(w http.ResponseWriter, r *http.Request) error {
return writeJSON(w, observation)
}
func serveDeleteObservation(w http.ResponseWriter, r *http.Request) error {
id, _ := strconv.ParseInt(mux.Vars(r)["Id"], 10, 0)
deleted, err := store.Observations.Delete(id)
if err != nil {
return err
}
if deleted {
w.WriteHeader(http.StatusOK)
}
return writeJSON(w, &models.Observation{})
}

View file

@ -124,3 +124,30 @@ func TestObservation_Update(t *testing.T) {
t.Error("!success")
}
}
func TestObservation_Delete(t *testing.T) {
setup()
want := newObservation()
calledDelete := false
store.Observations.(*models.MockObservationsService).Delete_ = func(id int64) (bool, error) {
if id != want.Id {
t.Errorf("wanted request for observation %d but got %d", want.Id, id)
}
calledDelete = true
return true, nil
}
success, err := apiClient.Observations.Delete(want.Id)
if err != nil {
t.Fatal(err)
}
if !calledDelete {
t.Error("!calledDelete")
}
if !success {
t.Error("!success")
}
}