Merge branch 'master' into clostridium

* master:
  Dropping ember-select2 for custom component
  Update getProperty helper
  #55, species
  Rest of strain MU
  strain.strainNameMU to component
  Refactor delete button
  Handle password change errors
  New Ajax Error util
  ember-cli 1.13.12

.gitignore

@@ -15,4 +15,3 @@
 /libpeerconnection.log
 npm-debug.log
 testem.log
-.divshot-cache

app/helpers/get-property.js

@@ -1,8 +1,7 @@
 import Ember from 'ember';
 
-// This will be unneccesary when ember 2.0 lands
+const { get, Helper: { helper } } = Ember;
-export function getProperty(params) {
-  return Ember.get(params[0], params[1]);
-}
 
-export default Ember.HTMLBars.makeBoundHelper(getProperty);
+export default helper(function(params) {
+  return get(params[0], params[1]);
+});

app/models/species.js

@@ -17,9 +17,4 @@ export default Model.extend({
   updatedBy   : attr('number'),
   sortOrder   : attr('number'),
   canEdit     : attr('boolean'),
-
-  // TODO: move this to component/helper
-  speciesNameMU: function() {
-    return Ember.String.htmlSafe(`<em>${this.get('speciesName')}</em>`);
-  }.property('speciesName').readOnly(),
 });

app/models/strain.js

@@ -2,6 +2,7 @@ import DS from 'ember-data';
 import Ember from 'ember';
 
 const { Model, hasMany, belongsTo, attr } = DS;
+const { computed } = Ember;
 
 export default Model.extend({
   measurements       : hasMany('measurements', { async: false }),
@@ -22,19 +23,14 @@ export default Model.extend({
   sortOrder          : attr('number'),
   canEdit            : attr('boolean'),
 
-  // TODO: move this to component/helper
+  // Used internally for sorting
-  strainNameMU: function() {
+  fullName: computed('species', 'strainName', function() {
-    let type = this.get('typeStrain') ? '<sup>T</sup>' : '';
-    return Ember.String.htmlSafe(`${this.get('strainName')}${type}`);
-  }.property('strainName', 'typeStrain').readOnly(),
-
-  // TODO: move this to component/helper
-  fullName: Ember.computed('species', 'strainName', function() {
     return `${this.get('species.speciesName')} ${this.get('strainNameMU')}`;
   }),
 
   // TODO: move this to component/helper
+  // Can't move until Select2 refactor
   fullNameMU: function() {
-    return Ember.String.htmlSafe(`<em>${this.get('species.speciesName')}</em> ${this.get('strainNameMU')}`);
+    return Ember.String.htmlSafe(`<em>${this.get('species.speciesName')}</em> ${this.get('strainName')}`);
   }.property('species', 'strainNameMU').readOnly(),
 });

app/pods/components/delete-button/component.js

@@ -2,10 +2,13 @@ import Ember from 'ember';
 
 export default Ember.Component.extend({
   tagName: 'button',
-  classNames: ["button-red", "smaller"],
+  classNames: ["button-red", "smaller", "delete"],
+  showConfirmDelete: false,
 
   click: function() {
-    if (window.confirm("Do you really want to delete this?")) {
+    if (!this.get('showConfirmDelete')) {
+      this.set('showConfirmDelete', true);
+    } else {
       this.attrs.delete();
     }
   },

app/pods/components/delete-button/template.hbs

@@ -1 +1,5 @@
-Delete
+{{#if showConfirmDelete}}
+  Are you sure?
+{{else}}
+  Delete
+{{/if}}

app/pods/components/strain-name/template.hbs

@@ -0,0 +1 @@
+{{strain.strainName}}{{{if strain.typeStrain '<sup>T</sup>' ''}}}

app/pods/components/x-select/component.js

@@ -0,0 +1,35 @@
+import Ember from 'ember';
+
+const { Component } = Ember;
+
+export default Component.extend({
+  tagName: 'select',
+  attributeBindings: [
+    'multiple',
+  ],
+
+  options: null,
+  selected: null,
+  nameAttr: null,
+
+  change: function() {
+    this.attrs.update(this.$().select2('val'));
+  },
+
+  didInsertElement: function() {
+    if (this.get('placeholder')) {
+      this.$().select2({
+        placeholder: this.get('placeholder'),
+      });
+    } else {
+      this.$().select2();
+    }
+  },
+
+  didRender: function() {
+    Ember.run.schedule('afterRender', this, function() {
+      this.$().select2('val', this.get('selected'));
+    });
+  },
+
+});

app/pods/components/x-select/template.hbs

@@ -0,0 +1,3 @@
+{{#each options as |option|}}
+  <option value={{option.id}}>{{get-property option nameAttr}}</option>
+{{/each}}

app/pods/protected/characteristics/show/measurements-table/template.hbs

@@ -17,7 +17,7 @@
       <tr>
         <td>
           {{#link-to 'protected.strains.show' row.strain.id}}
-            {{{row.strain.strainNameMU}}}
+            {{strain-name strain=row.strain}}
           {{/link-to}}
         </td>
         <td>

app/pods/protected/compare/controller.js

@@ -3,8 +3,8 @@ import Ember from 'ember';
 const { Controller } = Ember;
 
 export default Controller.extend({
-  selectedStrains: null,
+  selectedStrains: [],
-  selectedCharacteristics: null,
+  selectedCharacteristics: [],
 
   actions: {
     search: function(query) {

app/pods/protected/compare/results/route.js

@@ -30,8 +30,8 @@ export default Route.extend({
     }
 
     const compare = this.controllerFor('protected.compare');
-    compare.set('selectedStrains', params.strain_ids);
+    compare.set('selectedStrains', params.strain_ids.split(","));
-    compare.set('selectedCharacteristics', params.characteristic_ids);
+    compare.set('selectedCharacteristics', params.characteristic_ids.split(","));
 
     return this.get('ajax').request('/compare', { data: params });
   },
@@ -45,14 +45,14 @@ export default Route.extend({
     const compare = this.controllerFor('protected.compare');
 
     const strains = [];
-    const strain_ids = compare.get('selectedStrains').split(',');
+    const strain_ids = compare.get('selectedStrains');
     strain_ids.forEach((id) => {
       strains.push(this.store.peekRecord('strain', id));
     });
     controller.set('strains', strains);
 
     const characteristics = [];
-    const characteristic_ids = compare.get('selectedCharacteristics').split(',');
+    const characteristic_ids = compare.get('selectedCharacteristics');
     characteristic_ids.forEach((id) => {
       characteristics.push(this.store.peekRecord('characteristic', id));
     });

app/pods/protected/compare/select-form/component.js

@@ -10,8 +10,8 @@ export default Component.extend({
   "update-strains": null,
   "update-characteristics": null,
 
-  selectedStrains: null,
+  selectedStrains: [],
-  selectedCharacteristics: null,
+  selectedCharacteristics: [],
 
   updateStrains: function(selection) {
     this.set('selectedStrains', selection);
@@ -38,11 +38,11 @@ export default Component.extend({
       strains.forEach((strain) => {
         strain_ids.push(strain.get('id'));
       });
-      this.updateStrains(strain_ids.join(","));
+      this.updateStrains(strain_ids);
     },
 
     deselectAllStrains: function() {
-      this.updateStrains("");
+      this.updateStrains([]);
     },
 
     selectAllCharacteristics: function() {
@@ -51,11 +51,19 @@ export default Component.extend({
       chars.forEach((char) => {
         char_ids.push(char.get('id'));
       });
-      this.updateCharacteristics(char_ids.join(","));
+      this.updateCharacteristics(char_ids);
     },
 
     deselectAllCharacteristics: function() {
-      this.updateCharacteristics("");
+      this.updateCharacteristics([]);
+    },
+
+    updateStrainSelection: function(selection) {
+      this.updateStrains(selection);
+    },
+
+    updateCharacteristicsSelection: function(selection) {
+      this.updateCharacteristics(selection);
     },
   },
 });

app/pods/protected/compare/select-form/template.hbs

@@ -5,12 +5,12 @@
         <li>
           <label>Strains</label>
           {{
-            select-2
+            x-select
+            options=strains
+            nameAttr='fullNameMU'
             multiple=true
-            content=strains
+            selected=selectedStrains
-            value=selectedStrains
+            update=(action "updateStrainSelection")
-            optionValuePath="id"
-            optionLabelPath="fullNameMU"
             placeholder="Select one or more strains"
           }}
         </li>
@@ -25,12 +25,12 @@
         <li>
           <label>Characteristics</label>
           {{
-            select-2
+            x-select
+            options=characteristics
+            nameAttr='characteristicName'
             multiple=true
-            content=characteristics
+            selected=selectedCharacteristics
-            value=selectedCharacteristics
+            update=(action "updateCharacteristicsSelection")
-            optionValuePath="id"
-            optionLabelPath="characteristicName"
             placeholder="Select one or more characteristics"
           }}
         </li>

app/pods/protected/species/index/species-table/template.hbs

@@ -23,7 +23,7 @@
           {{#each species.strains as |strain index|}}
             {{if index ","}}
             {{#link-to 'protected.strains.show' strain.id}}
-              {{{strain.strainNameMU}}}
+              {{strain-name strain=strain}}
             {{/link-to}}
           {{/each}}
         </td>

app/pods/protected/species/show/species-card/template.hbs

@@ -14,7 +14,7 @@
               {{#each species.strains as |strain index|}}
                 <li>
                   {{#link-to 'protected.strains.show' strain.id}}
-                    {{{strain.strainNameMU}}}
+                    {{strain-name strain=strain}}
                   {{/link-to}}
                 </li>
               {{/each}}

app/pods/protected/species/species-form/template.hbs

@@ -19,7 +19,7 @@
         {{#each strains as |strain index|}}
           {{if index ","}}
           {{#link-to 'protected.strains.show' strain.id}}
-            {{{strain.strainNameMU}}}
+            {{strain-name strain=strain}}
           {{/link-to}}
         {{/each}}
         {{add-button label="Add Strain" link="protected.strains.new" canAdd=metaData.canAdd}}

app/pods/protected/strains/show/strain-card/template.hbs

@@ -1,7 +1,7 @@
 <div class="span-1">
   <fieldset class="flakes-information-box">
     <legend>
-      {{strain.strainNameMU}}
+      {{strain-name strain=strain}}
     </legend>
 
     {{! ROW 1 }}
@@ -10,7 +10,7 @@
         <dt>Species</dt>
         <dd>
           {{#link-to 'protected.species.show' strain.species.id}}
-            <em>{{strain.species.speciesNameMU}}</em>
+            <em>{{strain.species.speciesName}}</em>
           {{/link-to}}
         </dd>
       </dl>

app/pods/protected/strains/strain-form/template.hbs

@@ -15,11 +15,13 @@
     <div data-row-span="2">
       <div data-field-span="2">
         <label>Species</label>
-        <select onchange={{action "speciesDidChange" value="target.value"}}>
+        {{
-          {{#each speciesList as |speciesChoice|}}
+          x-select
-            <option value={{speciesChoice.id}} selected={{equal species.id speciesChoice.id}}>{{speciesChoice.speciesName}}</option>
+          options=speciesList
-          {{/each}}
+          nameAttr='speciesName'
-        </select>
+          selected=species.id
+          update=(action "speciesDidChange")
+        }}
       </div>
     </div>
     <div data-row-span="2">

app/pods/protected/users/changepassword/controller.js

@@ -1,4 +1,5 @@
 import Ember from 'ember';
+import ajaxErrorNew from '../../../../utils/ajax-error-new';
 
 const { Controller, inject: { service } } = Ember;
 
@@ -11,9 +12,12 @@ export default Controller.extend({
     save: function(password) {
       const id = this.get('currentUser.account.id');
       const data = { id: id, password: password };
-      this.get('ajax').post('/users/password', { data: data });
+      this.get('ajax').post('/users/password', { data: data }).then(() => {
-      this.transitionToRoute('protected.users.show', id);
+        this.transitionToRoute('protected.users.show', id);
-      this.get('flashMessages').information('Your password has been changed.');
+        this.get('flashMessages').information('Your password has been changed.');
+      }, (error) => {
+        ajaxErrorNew(error, this.get('flashMessages'));
+      });
     },
 
     cancel: function() {

app/utils/ajax-error-new.js

@@ -0,0 +1,7 @@
+export default function ajaxErrorNew(error, flash) {
+  flash.clearMessages();
+  error.errors.forEach((error) => {
+    const source = error.source.pointer.split('/');
+    flash.error(`${source[source.length-1].replace(/([A-Z])/g, ' $1').capitalize()} - ${error.detail}`);
+  });
+}

package.json

@@ -20,7 +20,7 @@
   "license": "MIT",
   "devDependencies": {
     "broccoli-asset-rev": "^2.2.0",
-    "ember-cli": "1.13.11",
+    "ember-cli": "1.13.12",
     "ember-cli-app-version": "^1.0.0",
     "ember-cli-babel": "^5.1.5",
     "ember-cli-content-security-policy": "0.4.0",
@@ -39,7 +39,6 @@
     "ember-disable-proxy-controllers": "^1.0.1",
     "ember-export-application-global": "^1.0.4",
     "ember-one-way-input": "0.1.3",
-    "ember-select-2": "1.3.0",
     "ember-simple-auth": "1.0.0"
   }
 }