From 35475c2b920ac1ec8d526acb61795884f3241645 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 11:02:23 -0700 Subject: [PATCH 01/14] Rough in some tests --- app/mirage/config.js | 15 ++++ app/mirage/factories/strains.js | 17 +++++ app/pods/protected/strains/index/template.hbs | 2 +- app/pods/protected/strains/show/template.hbs | 2 +- .../strains/strain-form/template.hbs | 4 +- tests/acceptance/strains-test.js | 76 +++++++++++++++++++ 6 files changed, 112 insertions(+), 4 deletions(-) create mode 100644 app/mirage/factories/strains.js create mode 100644 tests/acceptance/strains-test.js diff --git a/app/mirage/config.js b/app/mirage/config.js index 3982c0c..e39ccee 100644 --- a/app/mirage/config.js +++ b/app/mirage/config.js @@ -24,4 +24,19 @@ export function testConfig() { this.post('/characteristics'); this.get('/characteristics/:id'); this.put('/characteristics/:id'); + + this.get('/strains', function(db /*, request*/) { + return { + strains: db.strains, + species: db.species, + }; + }); + this.post('/strains'); + this.get('/strains/:id', function(db, request) { + return { + strain: db.strains.find(request.params.id), + species: db.species, // Just send back everything we've got + } + }); + this.put('/strains/:id'); } diff --git a/app/mirage/factories/strains.js b/app/mirage/factories/strains.js new file mode 100644 index 0000000..6165528 --- /dev/null +++ b/app/mirage/factories/strains.js @@ -0,0 +1,17 @@ +import Mirage, { faker } from 'ember-cli-mirage'; + +export default Mirage.Factory.extend({ + measurements: [], + characteristics: [], + species: 0, + strainName() { return faker.lorem.words().join(' '); }, + typeStrain: faker.random.boolean(), + accessionNumbers() { return faker.lorem.words().join(' '); }, + genbank() { return faker.lorem.words().join(' '); }, + wholeGenomeSequence() { return faker.lorem.words().join(' '); }, + isolatedFrom: faker.lorem.sentences(), + notes: faker.lorem.sentences(), + totalMeasurements: 0, + sortOrder: faker.random.number(), + canEdit: faker.random.boolean(), +}); diff --git a/app/pods/protected/strains/index/template.hbs b/app/pods/protected/strains/index/template.hbs index 077d22a..851f93b 100644 --- a/app/pods/protected/strains/index/template.hbs +++ b/app/pods/protected/strains/index/template.hbs @@ -1,5 +1,5 @@

{{genus-name}} Strains

-

Total strains: {{model.length}}

+

Total strains: {{model.length}}

{{add-button label="Add Strain" link="protected.strains.new" canAdd=metaData.canAdd}} diff --git a/app/pods/protected/strains/show/template.hbs b/app/pods/protected/strains/show/template.hbs index 8a10e60..87d5d4f 100644 --- a/app/pods/protected/strains/show/template.hbs +++ b/app/pods/protected/strains/show/template.hbs @@ -1,7 +1,7 @@
- Strain {{model.strainNameMU}} + {{model.strainNameMU}} {{! ROW 1 }} diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index 109d037..fef122d 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -4,7 +4,7 @@
- {{input value=strain.strainName}} + {{input value=strain.strainName class="strain-name"}}
@@ -62,7 +62,7 @@ Cancel {{#if strain.hasDirtyAttributes}} - {{/if}} diff --git a/tests/acceptance/strains-test.js b/tests/acceptance/strains-test.js new file mode 100644 index 0000000..a52e7ed --- /dev/null +++ b/tests/acceptance/strains-test.js @@ -0,0 +1,76 @@ +import Ember from 'ember'; +import { module, test } from 'qunit'; +import startApp from '../helpers/start-app'; +import { authenticateSession } from '../helpers/ember-simple-auth'; + +module('Acceptance | strains', { + beforeEach: function() { + this.application = startApp(); + authenticateSession(this.application, { + access_token: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJiYWN0ZGIiLCJzdWIiOiIxIiwiZXhwIjoxNDQ2NTAyMjI2LCJpYXQiOjE0NDY0OTg2MjZ9.vIjKHAsp2TkCV505EbtCo2xQT-2oQkB-Nv5y0b6E7Mg" + }); + server.create('users', { role: 'A', canEdit: true }); + }, + + afterEach: function() { + Ember.run(this.application, 'destroy'); + } +}); + +test('visiting /strains', function(assert) { + const species = server.create('species'); + const strains = server.createList('strains', 20, { species: species.id }); + visit('/strains'); + + andThen(function() { + assert.equal(currentURL(), '/strains'); + assert.equal(find(".flakes-table > tbody > tr").length, strains.length); + assert.equal(find("#total-strains").text(), "Total strains: 20"); + }); +}); + +test('visiting /strains/:id', function(assert) { + const species = server.create('species'); + const strain = server.create('strains', { species: species.id }); + visit(`/strains/${strain.id}`); + + andThen(function() { + assert.equal(currentURL(), `/strains/${strain.id}`); + const typeStrain = strain.typeStrain ? 'T' : ''; + assert.equal(find(".flakes-information-box > legend").text().trim(), `${strain.strainName}${typeStrain}`); + }); +}); + +test('editing /strains/:id/edit', function(assert) { + const species = server.create('species'); + const strain = server.create('strains', { canEdit: true , species: species.id }); + visit(`/strains/${strain.id}/edit`); + + andThen(function() { + assert.equal(currentURL(), `/strains/${strain.id}/edit`); + + fillIn('.strain-name', 'Revised Strain Name'); + click('.save-strain'); + + andThen(function() { + assert.equal(currentURL(), `/strains/${strain.id}`); + const typeStrain = strain.typeStrain ? 'T' : ''; + assert.equal(find(".flakes-information-box > legend").text().trim(), `Revised Strain Name${typeStrain}`); + }); + }); +}); + +test('creating /strains/new', function(assert) { + visit(`/strains/new`); + + andThen(function() { + assert.equal(currentURL(), `/strains/new`); + fillIn('.strain-name', 'New Strain Name'); + click('.save-strain'); + + andThen(function() { + assert.equal(find(".flakes-information-box > legend").text().trim(), `New Strain Name`); + assert.equal(server.db.strains.length, 1); + }); + }); +}); From 85d861da27fa10c71b867e112dd72ba34474a0fc Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 11:13:22 -0700 Subject: [PATCH 02/14] Refactor strains/index --- .../species/index/species-table/component.js | 4 +-- .../protected/strains/index/controller.js | 6 ---- app/pods/protected/strains/index/route.js | 11 ++----- .../strains/index/strain-table/component.js | 12 ++++++++ .../strains/index/strain-table/template.hbs | 26 +++++++++++++++++ app/pods/protected/strains/index/template.hbs | 29 +++---------------- 6 files changed, 46 insertions(+), 42 deletions(-) delete mode 100644 app/pods/protected/strains/index/controller.js create mode 100644 app/pods/protected/strains/index/strain-table/component.js create mode 100644 app/pods/protected/strains/index/strain-table/template.hbs diff --git a/app/pods/protected/species/index/species-table/component.js b/app/pods/protected/species/index/species-table/component.js index d58f509..528c48d 100644 --- a/app/pods/protected/species/index/species-table/component.js +++ b/app/pods/protected/species/index/species-table/component.js @@ -1,12 +1,12 @@ import Ember from 'ember'; import SetupMetaData from '../../../../../mixins/setup-metadata'; -const { Component } = Ember; +const { Component, computed: { sort } } = Ember; export default Component.extend(SetupMetaData, { species: null, sortParams: ['speciesName', 'strainCount'], - sortedSpecies: Ember.computed.sort('species', 'sortParams'), + sortedSpecies: sort('species', 'sortParams'), }); diff --git a/app/pods/protected/strains/index/controller.js b/app/pods/protected/strains/index/controller.js deleted file mode 100644 index ec348db..0000000 --- a/app/pods/protected/strains/index/controller.js +++ /dev/null @@ -1,6 +0,0 @@ -import Ember from 'ember'; - -export default Ember.Controller.extend({ - sortParams: ['sortOrder'], - sortedStrains: Ember.computed.sort('model', 'sortParams'), -}); diff --git a/app/pods/protected/strains/index/route.js b/app/pods/protected/strains/index/route.js index e5582d7..627760f 100644 --- a/app/pods/protected/strains/index/route.js +++ b/app/pods/protected/strains/index/route.js @@ -1,17 +1,10 @@ import Ember from 'ember'; -export default Ember.Route.extend({ - currentUser: Ember.inject.service('session-account'), +const { Route } = Ember; +export default Route.extend({ model: function() { return this.store.findAll('strain'); }, - setupController: function(controller, model) { - controller.set('model', model); - this.get('currentUser.account').then((user) => { - controller.set('metaData', user.get('metaData')); - }); - }, - }); diff --git a/app/pods/protected/strains/index/strain-table/component.js b/app/pods/protected/strains/index/strain-table/component.js new file mode 100644 index 0000000..0e801ca --- /dev/null +++ b/app/pods/protected/strains/index/strain-table/component.js @@ -0,0 +1,12 @@ +import Ember from 'ember'; +import SetupMetaData from '../../../../../mixins/setup-metadata'; + +const { Component, computed: { sort } } = Ember; + +export default Component.extend(SetupMetaData, { + strains: null, + + sortParams: ['fullNameMU'], + sortedStrains: sort('strains', 'sortParams'), + +}); diff --git a/app/pods/protected/strains/index/strain-table/template.hbs b/app/pods/protected/strains/index/strain-table/template.hbs new file mode 100644 index 0000000..bb13d76 --- /dev/null +++ b/app/pods/protected/strains/index/strain-table/template.hbs @@ -0,0 +1,26 @@ +

Total strains: {{strains.length}}

+ +{{add-button label="Add Strain" link="protected.strains.new" canAdd=metaData.canAdd}} + + + + + + + + + + {{#each sortedStrains as |strain|}} + + + + + {{/each}} + +
SpeciesTotal Measurements
+ {{#link-to 'protected.strains.show' strain classBinding="data.typeStrain:type-strain"}} + {{strain.fullNameMU}} + {{/link-to}} + + {{strain.totalMeasurements}} +
diff --git a/app/pods/protected/strains/index/template.hbs b/app/pods/protected/strains/index/template.hbs index 851f93b..d441386 100644 --- a/app/pods/protected/strains/index/template.hbs +++ b/app/pods/protected/strains/index/template.hbs @@ -1,27 +1,6 @@

{{genus-name}} Strains

-

Total strains: {{model.length}}

-{{add-button label="Add Strain" link="protected.strains.new" canAdd=metaData.canAdd}} - - - - - - - - - - {{#each sortedStrains as |row|}} - - - - - {{/each}} - -
SpeciesTotal Measurements
- {{#link-to 'protected.strains.show' row classBinding="data.typeStrain:type-strain"}} - {{row.fullNameMU}} - {{/link-to}} - - {{row.totalMeasurements}} -
+{{ + protected/strains/index/strain-table + strains=model +}} From 04486880a09ea8e0d0a30cb3ca2292764c1a6997 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 11:41:04 -0700 Subject: [PATCH 03/14] Begin refactoring strains/show Will address measurements table later --- app/pods/protected/strains/show/controller.js | 13 +-- .../show/measurements-table-row/component.js | 4 +- .../show/measurements-table/component.js | 4 +- app/pods/protected/strains/show/route.js | 6 +- .../strains/show/strain-card/component.js | 14 +++ .../strains/show/strain-card/template.hbs | 105 +++++++++++++++++ app/pods/protected/strains/show/template.hbs | 110 +----------------- 7 files changed, 139 insertions(+), 117 deletions(-) create mode 100644 app/pods/protected/strains/show/strain-card/component.js create mode 100644 app/pods/protected/strains/show/strain-card/template.hbs diff --git a/app/pods/protected/strains/show/controller.js b/app/pods/protected/strains/show/controller.js index 7128b9a..e5e3e77 100644 --- a/app/pods/protected/strains/show/controller.js +++ b/app/pods/protected/strains/show/controller.js @@ -1,12 +1,9 @@ import Ember from 'ember'; +import DeleteModel from '../../../../mixins/delete-model'; -export default Ember.Controller.extend({ - actions: { - delete: function() { - this.get('model').destroyRecord().then(() => { - this.transitionToRoute('protected.strains.index'); - }); - }, - }, +const { Controller } = Ember; +export default Controller.extend(DeleteModel, { + // Required for DeleteModel mixin + transitionRoute: 'protected.strains.index', }); diff --git a/app/pods/protected/strains/show/measurements-table-row/component.js b/app/pods/protected/strains/show/measurements-table-row/component.js index b4220cd..8ad1ba7 100644 --- a/app/pods/protected/strains/show/measurements-table-row/component.js +++ b/app/pods/protected/strains/show/measurements-table-row/component.js @@ -1,7 +1,9 @@ import Ember from 'ember'; import ajaxError from '../../../../../utils/ajax-error'; -export default Ember.Component.extend({ +const { Component } = Ember; + +export default Component.extend({ tagName: 'tr', isEditing: false, diff --git a/app/pods/protected/strains/show/measurements-table/component.js b/app/pods/protected/strains/show/measurements-table/component.js index 07d94c6..6cbf880 100644 --- a/app/pods/protected/strains/show/measurements-table/component.js +++ b/app/pods/protected/strains/show/measurements-table/component.js @@ -1,6 +1,8 @@ import Ember from 'ember'; -export default Ember.Component.extend({ +const { Component } = Ember; + +export default Component.extend({ measurementsPresent: function() { return this.get('model.measurements.length') > 0; }.property('model.measurements'), diff --git a/app/pods/protected/strains/show/route.js b/app/pods/protected/strains/show/route.js index 0a17d8b..ea320bd 100644 --- a/app/pods/protected/strains/show/route.js +++ b/app/pods/protected/strains/show/route.js @@ -1,8 +1,10 @@ import Ember from 'ember'; -export default Ember.Route.extend({ +const { Route } = Ember; + +export default Route.extend({ model: function(params) { - return this.store.findRecord('strain', params.strain_id, { reload: true }); + return this.store.findRecord('strain', params.strain_id); }, }); diff --git a/app/pods/protected/strains/show/strain-card/component.js b/app/pods/protected/strains/show/strain-card/component.js new file mode 100644 index 0000000..40802c8 --- /dev/null +++ b/app/pods/protected/strains/show/strain-card/component.js @@ -0,0 +1,14 @@ +import Ember from 'ember'; + +const { Component } = Ember; + +export default Component.extend({ + strain: null, + "on-delete": null, + + actions: { + deleteStrain: function() { + return this.attrs['on-delete'](); + }, + }, +}); diff --git a/app/pods/protected/strains/show/strain-card/template.hbs b/app/pods/protected/strains/show/strain-card/template.hbs new file mode 100644 index 0000000..989db71 --- /dev/null +++ b/app/pods/protected/strains/show/strain-card/template.hbs @@ -0,0 +1,105 @@ +
+
+ + {{strain.strainNameMU}} + + + {{! ROW 1 }} +
+
+
Species
+
+ {{#link-to 'protected.species.show' strain.species.id}} + {{strain.species.speciesNameMU}} + {{/link-to}} +
+
+
+
Type Strain?
+
+ {{if strain.typeStrain 'Yes' 'No'}} +
+
+
+ + {{! ROW 2 }} +
+
+
Accession Numbers
+
+ {{strain.accessionNumbers}} +
+
+
+
Genbank
+
+ {{genbank-url genbank=strain.genbank}} +
+
+
+
Whole Genome Sequence
+
+ {{genbank-url genbank=strain.wholeGenomeSequence}} +
+
+
+ + {{! ROW 3 }} +
+
+
Isolated From
+
+ {{{strain.isolatedFrom}}} +
+
+
+ + {{! ROW 4 }} +
+
+
Notes
+
+ {{#if strain.notes}} + {{{strain.notes}}} + {{else}} + No notes. + {{/if}} +
+
+
+ + {{! ROW 5 }} +
+
+
Characteristics
+
+ {{ + protected/strains/show/measurements-table + model=strain + canEdit=false + canAdd=false + }} +
+
+
+ + {{! ROW 6 }} +
+
+
Record Created
+
{{null-time strain.createdAt 'LL'}}
+
+
+
Record Updated
+
{{null-time strain.updatedAt 'LL'}}
+
+
+
+
+{{#if strain.canEdit}} +
+ {{#link-to 'protected.strains.edit' strain class="button-gray smaller"}} + Edit + {{/link-to}} + {{delete-button delete=(action 'deleteStrain')}} +{{/if}} diff --git a/app/pods/protected/strains/show/template.hbs b/app/pods/protected/strains/show/template.hbs index 87d5d4f..32d23d6 100644 --- a/app/pods/protected/strains/show/template.hbs +++ b/app/pods/protected/strains/show/template.hbs @@ -1,105 +1,5 @@ -
-
- - {{model.strainNameMU}} - - - {{! ROW 1 }} -
-
-
Species
-
- {{#link-to 'protected.species.show' model.species.id}} - {{model.species.speciesNameMU}} - {{/link-to}} -
-
-
-
Type Strain?
-
- {{if model.typeStrain 'Yes' 'No'}} -
-
-
- - {{! ROW 2 }} -
-
-
Accession Numbers
-
- {{model.accessionNumbers}} -
-
-
-
Genbank
-
- {{genbank-url genbank=model.genbank}} -
-
-
-
Whole Genome Sequence
-
- {{genbank-url genbank=model.wholeGenomeSequence}} -
-
-
- - {{! ROW 3 }} -
-
-
Isolated From
-
- {{{model.isolatedFrom}}} -
-
-
- - {{! ROW 4 }} -
-
-
Notes
-
- {{#if model.notes}} - {{{model.notes}}} - {{else}} - No notes. - {{/if}} -
-
-
- - {{! ROW 5 }} -
-
-
Characteristics
-
- {{ - protected/strains/show/measurements-table - model=model - canEdit=false - canAdd=false - }} -
-
-
- - {{! ROW 6 }} -
-
-
Record Created
-
{{null-time model.createdAt 'LL'}}
-
-
-
Record Updated
-
{{null-time model.updatedAt 'LL'}}
-
-
-
-
-{{#if model.canEdit}} -
- {{#link-to 'protected.strains.edit' model.id class="button-gray smaller"}} - Edit - {{/link-to}} - {{delete-button delete=(action 'delete')}} -{{/if}} +{{ + protected/strains/show/strain-card + strain=model + on-delete=(action 'delete') +}} From 29c507af6b4b834e4078c6ab526e24d1bb238e4b Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 12:57:12 -0700 Subject: [PATCH 04/14] Refactor strain form and edit strain --- app/pods/protected/strains/edit/controller.js | 34 ++------ app/pods/protected/strains/edit/route.js | 41 ++++++---- app/pods/protected/strains/edit/template.hbs | 8 +- .../strains/strain-form/component.js | 78 +++++++++++++++++-- .../strains/strain-form/template.hbs | 30 +++---- 5 files changed, 122 insertions(+), 69 deletions(-) diff --git a/app/pods/protected/strains/edit/controller.js b/app/pods/protected/strains/edit/controller.js index 2f84780..a44ea40 100644 --- a/app/pods/protected/strains/edit/controller.js +++ b/app/pods/protected/strains/edit/controller.js @@ -1,32 +1,10 @@ import Ember from 'ember'; -import ajaxError from '../../../../utils/ajax-error'; +import SaveModel from '../../../../mixins/save-model'; -export default Ember.Controller.extend({ - actions: { - save: function() { - let strain = this.get('strain'); +const { Controller } = Ember; - if (strain.get('hasDirtyAttributes')) { - strain.save().then((strain) => { - this.transitionToRoute('protected.strains.show', strain); - }, () => { - ajaxError(strain.get('errors'), this.get('flashMessages')); - }); - } else { - strain.destroyRecord().then(() => { - this.transitionToRoute('protected.strains.show', strain); - }); - } - }, - - cancel: function() { - let strain = this.get('strain'); - - strain.get('errors').clear(); - strain.rollbackAttributes(); - - this.transitionToRoute('protected.strains.show', strain); - }, - - }, +export default Controller.extend(SaveModel, { + // Required for SaveModel mixin + fallbackRouteSave: 'protected.strains.show', + fallbackRouteCancel: 'protected.strains.show', }); diff --git a/app/pods/protected/strains/edit/route.js b/app/pods/protected/strains/edit/route.js index ee75d51..7efe43d 100644 --- a/app/pods/protected/strains/edit/route.js +++ b/app/pods/protected/strains/edit/route.js @@ -1,35 +1,42 @@ import Ember from 'ember'; +import ElevatedAccess from '../../../../mixins/elevated-access'; -export default Ember.Route.extend({ - currentUser: Ember.inject.service('session-account'), +const { Route } = Ember; - beforeModel: function(transition) { - this._super(transition); - this.get('currentUser.account').then((user) => { - if (user.get('isReader')) { - this.transitionTo('protected.strains.index'); - } - }); - }, +export default Route.extend(ElevatedAccess, { + // Required for ElevatedAccess mixin + fallbackRouteBefore: 'protected.strains.index', + fallbackRouteAfter: 'protected.strains.show', model: function(params) { return Ember.RSVP.hash({ - strain: this.store.find('strain', params.strain_id), + strain: this.store.findRecord('strain', params.strain_id), species: this.store.findAll('species'), // Need for dropdown }); }, + // Overriding afterModel because of RSVP hash afterModel: function(models) { - if (!models.strain.get('canEdit')) { - this.transitionTo('strains.show', models.strain.get('id')); + if (!models.strain.get('isNew') && !models.strain.get('canEdit')) { + this.transitionTo(this.get('fallbackRouteAfter'), models.strain.get('id')); } }, + // Setting up controller because of RSVP hash setupController: function(controller, models) { - controller.setProperties(models); - this.get('currentUser.account').then((user) => { - controller.set('metaData', user.get('metaData')); - }); + controller.set('model', models.strain); + controller.set('speciesList', models.species); }, + actions: { + // Overriding willTransition because of RSVP hash + willTransition: function(/*transition*/) { + const controller = this.get('controller'); + const model = controller.get('model'); + + if (model.get('isNew')) { + model.destroyRecord(); + } + }, + }, }); diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index a4885d6..822ac93 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -1,8 +1,8 @@ {{ protected/strains/strain-form - strain=strain - species=species + strain=model + speciesList=speciesList canAdd=metaData.canAdd - save="save" - cancel="cancel" + on-save=(action "save") + on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index 8ac9027..07841a7 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -1,21 +1,89 @@ import Ember from 'ember'; +import SetupMetaData from '../../../../mixins/setup-metadata'; + +const { Component } = Ember; + +export default Component.extend(SetupMetaData, { + // Read-only attributes + strain: null, + isNew: null, + isDirty: false, + speciesList: null, + + // Actions + "on-save": null, + "on-cancel": null, + "on-update": null, + + // Property mapping + propertiesList: ['strainName', 'typeStrain', 'species', 'isolatedFrom', 'accessionNumbers', 'genbank', 'wholeGenomeSequence', 'notes'], + strainName: null, + typeStrain: null, + species: null, + isolatedFrom: null, + accessionNumbers: null, + genbank: null, + wholeGenomeSequence: null, + notes: null, + + resetOnInit: Ember.on('init', function() { + this.get('propertiesList').forEach((field) => { + const valueInStrain = this.get('strain').get(field); + this.set(field, valueInStrain); + }); + // Read-only attributes + this.set('isNew', this.get('strain.isNew')); + }), + + updateField: function(property, value) { + this.set(property, value); + // Manually compare against passed in value + if (this.get('strain').get(property) !== value) { + this.set('isDirty', true); + } else { + this.set('isDirty', false); + } + }, -export default Ember.Component.extend({ actions: { save: function() { - this.sendAction('save'); + return this.attrs['on-save'](this.getProperties(this.get('propertiesList'))); }, cancel: function() { - this.sendAction('cancel'); + return this.attrs['on-cancel'](); + }, + + strainNameDidChange: function(value) { + this.updateField('strainName', value); + }, + + typeStrainDidChange: function() { + this.updateField('typeStrain', !this.get('typeStrain')); + }, + + speciesDidChange: function(value) { + this.updateField('species', value); }, isolatedFromDidChange: function(value) { - this.set('strain.isolatedFrom', value); + this.updateField('isolatedFrom', value); + }, + + accessionNumbersNameDidChange: function(value) { + this.updateField('accessionNumbers', value); + }, + + genbankDidChange: function(value) { + this.updateField('genbank', value); + }, + + wholeGenomeSequenceDidChange: function(value) { + this.updateField('wholeGenomeSequence', value); }, notesDidChange: function(value) { - this.set('strain.notes', value); + this.updateField('strain.notes', value); }, }, }); diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index fef122d..a959f4f 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -1,51 +1,51 @@
- {{strain.strainName}} + {{strainName}}
- {{input value=strain.strainName class="strain-name"}} + {{one-way-input type="text" class="strain-name" value=strainName update=(action "strainNameDidChange")}}
- {{input type="checkbox" checked=strain.typeStrain}} {{if strain.typeStrain 'Yes' 'No'}} + + {{if typeStrain 'Yes' 'No'}}
- {{ - select-2 - content=species - optionLabelPath="speciesName" - value=strain.species - }} +
- {{text-editor value=strain.isolatedFrom update=(action "isolatedFromDidChange")}} + {{text-editor value=isolatedFrom update=(action "isolatedFromDidChange")}}
- {{input value=strain.accessionNumbers}} + {{one-way-input type="text" class="accession-numbers" value=accessionNumbers update=(action "accessionNumbersNameDidChange")}}
- {{input value=strain.genbank}} + {{one-way-input type="text" class="genbank" value=genbank update=(action "genbankDidChange")}}
- {{input value=strain.wholeGenomeSequence}} + {{one-way-input type="text" class="whole-genome-sequenc" value=wholeGenomeSequence update=(action "wholeGenomeSequenceDidChange")}}
- {{text-editor value=strain.notes update=(action "notesDidChange")}} + {{text-editor value=notes update=(action "notesDidChange")}}
@@ -61,7 +61,7 @@ Cancel - {{#if strain.hasDirtyAttributes}} + {{#if isDirty}} From fa5b741e357a40f7b8ae66d7536d2cd84e15637e Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 14:31:38 -0700 Subject: [PATCH 05/14] Refactor strains/new --- app/mirage/config.js | 2 +- app/mixins/save-model.js | 15 +++----- app/models/strain.js | 4 +++ app/pods/protected/strains/edit/template.hbs | 1 - .../strains/index/strain-table/component.js | 2 +- app/pods/protected/strains/new/controller.js | 31 ++++------------ app/pods/protected/strains/new/route.js | 35 +++++++++++-------- app/pods/protected/strains/new/template.hbs | 8 ++--- .../strains/show/strain-card/template.hbs | 2 +- .../strains/strain-form/component.js | 3 +- .../strains/strain-form/template.hbs | 2 +- 11 files changed, 45 insertions(+), 60 deletions(-) diff --git a/app/mirage/config.js b/app/mirage/config.js index e39ccee..935eb17 100644 --- a/app/mirage/config.js +++ b/app/mirage/config.js @@ -36,7 +36,7 @@ export function testConfig() { return { strain: db.strains.find(request.params.id), species: db.species, // Just send back everything we've got - } + }; }); this.put('/strains/:id'); } diff --git a/app/mixins/save-model.js b/app/mixins/save-model.js index 8d3b233..d4459e3 100644 --- a/app/mixins/save-model.js +++ b/app/mixins/save-model.js @@ -13,17 +13,12 @@ export default Mixin.create({ const fallbackRoute = this.get('fallbackRouteSave'); model.setProperties(properties); - - if (model.get('hasDirtyAttributes')) { - model.save().then((model) => { - this.get('flashMessages').clearMessages(); - this.transitionToRoute(fallbackRoute, model); - }, () => { - ajaxError(model.get('errors'), this.get('flashMessages')); - }); - } else { + model.save().then((model) => { + this.get('flashMessages').clearMessages(); this.transitionToRoute(fallbackRoute, model); - } + }, () => { + ajaxError(model.get('errors'), this.get('flashMessages')); + }); }, cancel: function() { diff --git a/app/models/strain.js b/app/models/strain.js index 72d4ff6..0c59f2f 100644 --- a/app/models/strain.js +++ b/app/models/strain.js @@ -25,6 +25,10 @@ export default DS.Model.extend({ return Ember.String.htmlSafe(`${this.get('strainName')}${type}`); }.property('strainName', 'typeStrain').readOnly(), + fullName: Ember.computed('species', 'strainName', function() { + return `${this.get('species.speciesName')} ${this.get('strainNameMU')}`; + }), + fullNameMU: function() { return Ember.String.htmlSafe(`${this.get('species.speciesName')} ${this.get('strainNameMU')}`); }.property('species', 'strainNameMU').readOnly(), diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index 822ac93..1ae2d5b 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -2,7 +2,6 @@ protected/strains/strain-form strain=model speciesList=speciesList - canAdd=metaData.canAdd on-save=(action "save") on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/index/strain-table/component.js b/app/pods/protected/strains/index/strain-table/component.js index 0e801ca..7b3b21c 100644 --- a/app/pods/protected/strains/index/strain-table/component.js +++ b/app/pods/protected/strains/index/strain-table/component.js @@ -6,7 +6,7 @@ const { Component, computed: { sort } } = Ember; export default Component.extend(SetupMetaData, { strains: null, - sortParams: ['fullNameMU'], + sortParams: ['fullName'], sortedStrains: sort('strains', 'sortParams'), }); diff --git a/app/pods/protected/strains/new/controller.js b/app/pods/protected/strains/new/controller.js index d3e1b36..a38edbb 100644 --- a/app/pods/protected/strains/new/controller.js +++ b/app/pods/protected/strains/new/controller.js @@ -1,29 +1,10 @@ import Ember from 'ember'; -import ajaxError from '../../../../utils/ajax-error'; +import SaveModel from '../../../../mixins/save-model'; -export default Ember.Controller.extend({ - actions: { - save: function() { - let strain = this.get('strain'); +const { Controller } = Ember; - if (strain.get('hasDirtyAttributes')) { - strain.save().then((strain) => { - this.transitionToRoute('protected.strains.show', strain); - }, () => { - ajaxError(strain.get('errors'), this.get('flashMessages')); - }); - } else { - strain.destroyRecord().then(() => { - this.transitionToRoute('protected.strains.index'); - }); - } - }, - - cancel: function() { - this.get('strain').destroyRecord().then(() => { - this.transitionToRoute('protected.strains.index'); - }); - }, - - }, +export default Controller.extend(SaveModel, { + // Required for SaveModel mixin + fallbackRouteSave: 'protected.strains.show', + fallbackRouteCancel: 'protected.strains.index', }); diff --git a/app/pods/protected/strains/new/route.js b/app/pods/protected/strains/new/route.js index 837b713..a9f4c6f 100644 --- a/app/pods/protected/strains/new/route.js +++ b/app/pods/protected/strains/new/route.js @@ -1,16 +1,12 @@ import Ember from 'ember'; +import ElevatedAccess from '../../../../mixins/elevated-access'; -export default Ember.Route.extend({ - currentUser: Ember.inject.service('session-account'), +const { Route } = Ember; - beforeModel: function(transition) { - this._super(transition); - this.get('currentUser.account').then((user) => { - if (user.get('isReader')) { - this.transitionTo('protected.strains.index'); - } - }); - }, +export default Route.extend(ElevatedAccess, { + // Required for ElevatedAccess mixin + fallbackRouteBefore: 'protected.strains.index', + fallbackRouteAfter: 'protected.strains.show', model: function() { return Ember.RSVP.hash({ @@ -19,19 +15,28 @@ export default Ember.Route.extend({ }); }, + // Overriding afterModel because of RSVP hash + afterModel: function(models) { + if (!models.strain.get('isNew') && !models.strain.get('canEdit')) { + this.transitionTo(this.get('fallbackRouteAfter'), models.strain.get('id')); + } + }, + + // Setting up controller because of RSVP hash setupController: function(controller, models) { - controller.setProperties(models); + controller.set('model', models.strain); + controller.set('speciesList', models.species); }, actions: { + // Overriding willTransition because of RSVP hash willTransition: function(/*transition*/) { const controller = this.get('controller'); - const strain = controller.get('strain'); + const model = controller.get('model'); - if (strain.get('isNew')) { - strain.destroyRecord(); + if (model.get('isNew')) { + model.destroyRecord(); } }, }, - }); diff --git a/app/pods/protected/strains/new/template.hbs b/app/pods/protected/strains/new/template.hbs index d9c4d43..1ae2d5b 100644 --- a/app/pods/protected/strains/new/template.hbs +++ b/app/pods/protected/strains/new/template.hbs @@ -1,7 +1,7 @@ {{ protected/strains/strain-form - strain=strain - species=species - save="save" - cancel="cancel" + strain=model + speciesList=speciesList + on-save=(action "save") + on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/show/strain-card/template.hbs b/app/pods/protected/strains/show/strain-card/template.hbs index 989db71..58ff553 100644 --- a/app/pods/protected/strains/show/strain-card/template.hbs +++ b/app/pods/protected/strains/show/strain-card/template.hbs @@ -98,7 +98,7 @@
{{#if strain.canEdit}}
- {{#link-to 'protected.strains.edit' strain class="button-gray smaller"}} + {{#link-to 'protected.strains.edit' strain.id class="button-gray smaller"}} Edit {{/link-to}} {{delete-button delete=(action 'deleteStrain')}} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index 07841a7..b5544f3 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -63,7 +63,8 @@ export default Component.extend(SetupMetaData, { }, speciesDidChange: function(value) { - this.updateField('species', value); + const newSpecies = this.get('speciesList').findBy('id', value); + this.updateField('species', newSpecies); }, isolatedFromDidChange: function(value) { diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index a959f4f..ea27230 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -17,7 +17,7 @@
From 48cd1f4f39e82513287e992662e1cb02b2dda555 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 14:35:17 -0700 Subject: [PATCH 06/14] Step one, move up to pod root --- .../strains/{show => }/measurements-table-row/component.js | 0 .../strains/{show => }/measurements-table-row/template.hbs | 0 .../strains/{show => }/measurements-table/component.js | 0 .../strains/{show => measurements-table}/loading/template.hbs | 0 .../strains/{show => }/measurements-table/template.hbs | 2 +- .../strains/show/measurements-table/loading/template.hbs | 1 - app/pods/protected/strains/show/strain-card/template.hbs | 2 +- app/pods/protected/strains/strain-form/template.hbs | 2 +- 8 files changed, 3 insertions(+), 4 deletions(-) rename app/pods/protected/strains/{show => }/measurements-table-row/component.js (100%) rename app/pods/protected/strains/{show => }/measurements-table-row/template.hbs (100%) rename app/pods/protected/strains/{show => }/measurements-table/component.js (100%) rename app/pods/protected/strains/{show => measurements-table}/loading/template.hbs (100%) rename app/pods/protected/strains/{show => }/measurements-table/template.hbs (96%) delete mode 100644 app/pods/protected/strains/show/measurements-table/loading/template.hbs diff --git a/app/pods/protected/strains/show/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js similarity index 100% rename from app/pods/protected/strains/show/measurements-table-row/component.js rename to app/pods/protected/strains/measurements-table-row/component.js diff --git a/app/pods/protected/strains/show/measurements-table-row/template.hbs b/app/pods/protected/strains/measurements-table-row/template.hbs similarity index 100% rename from app/pods/protected/strains/show/measurements-table-row/template.hbs rename to app/pods/protected/strains/measurements-table-row/template.hbs diff --git a/app/pods/protected/strains/show/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js similarity index 100% rename from app/pods/protected/strains/show/measurements-table/component.js rename to app/pods/protected/strains/measurements-table/component.js diff --git a/app/pods/protected/strains/show/loading/template.hbs b/app/pods/protected/strains/measurements-table/loading/template.hbs similarity index 100% rename from app/pods/protected/strains/show/loading/template.hbs rename to app/pods/protected/strains/measurements-table/loading/template.hbs diff --git a/app/pods/protected/strains/show/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs similarity index 96% rename from app/pods/protected/strains/show/measurements-table/template.hbs rename to app/pods/protected/strains/measurements-table/template.hbs index a9a45dd..25b0c27 100644 --- a/app/pods/protected/strains/show/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -41,7 +41,7 @@ {{#each sortedMeasurements as |measurement|}} {{ - protected/strains/show/measurements-table-row + protected/strains/measurements-table-row row=measurement canEdit=canEdit }} diff --git a/app/pods/protected/strains/show/measurements-table/loading/template.hbs b/app/pods/protected/strains/show/measurements-table/loading/template.hbs deleted file mode 100644 index e5a3e05..0000000 --- a/app/pods/protected/strains/show/measurements-table/loading/template.hbs +++ /dev/null @@ -1 +0,0 @@ -{{loading-panel}} diff --git a/app/pods/protected/strains/show/strain-card/template.hbs b/app/pods/protected/strains/show/strain-card/template.hbs index 58ff553..86e281f 100644 --- a/app/pods/protected/strains/show/strain-card/template.hbs +++ b/app/pods/protected/strains/show/strain-card/template.hbs @@ -74,7 +74,7 @@
Characteristics
{{ - protected/strains/show/measurements-table + protected/strains/measurements-table model=strain canEdit=false canAdd=false diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index ea27230..908020f 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -51,7 +51,7 @@
{{ - protected/strains/show/measurements-table + protected/strains/measurements-table model=strain canEdit=strain.canEdit canAdd=canAdd From fbfbdf19d1bbddf92ddb1b38137b2136c8401a28 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 15:42:20 -0700 Subject: [PATCH 07/14] WIP --- app/pods/protected/strains/edit/controller.js | 8 ++++ app/pods/protected/strains/edit/template.hbs | 1 + .../measurements-table-row/component.js | 3 +- .../strains/measurements-table/component.js | 47 ++++++++++--------- .../strains/measurements-table/template.hbs | 20 ++++---- .../strains/show/strain-card/template.hbs | 2 +- .../strains/strain-form/component.js | 5 ++ .../strains/strain-form/template.hbs | 5 +- 8 files changed, 54 insertions(+), 37 deletions(-) diff --git a/app/pods/protected/strains/edit/controller.js b/app/pods/protected/strains/edit/controller.js index a44ea40..d3640c7 100644 --- a/app/pods/protected/strains/edit/controller.js +++ b/app/pods/protected/strains/edit/controller.js @@ -7,4 +7,12 @@ export default Controller.extend(SaveModel, { // Required for SaveModel mixin fallbackRouteSave: 'protected.strains.show', fallbackRouteCancel: 'protected.strains.show', + + actions: { + addCharacteristic: function() { + return this.store.createRecord('measurement', { + characteristic: this.store.createRecord('characteristic', { sortOrder: -999 }), + }); + }, + }, }); diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index 1ae2d5b..c36aa54 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -2,6 +2,7 @@ protected/strains/strain-form strain=model speciesList=speciesList + add-characteristic=(action "addCharacteristic") on-save=(action "save") on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index 8ad1ba7..c6983d7 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -1,11 +1,12 @@ import Ember from 'ember'; -import ajaxError from '../../../../../utils/ajax-error'; +import ajaxError from '../../../../utils/ajax-error'; const { Component } = Ember; export default Component.extend({ tagName: 'tr', isEditing: false, + allCharacteristics: null, oldCharacteristicId: function() { let json = this.get('row').toJSON(); diff --git a/app/pods/protected/strains/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js index 6cbf880..a83e25e 100644 --- a/app/pods/protected/strains/measurements-table/component.js +++ b/app/pods/protected/strains/measurements-table/component.js @@ -1,48 +1,49 @@ import Ember from 'ember'; -const { Component } = Ember; +const { Component, computed } = Ember; +const { sort } = computed; export default Component.extend({ - measurementsPresent: function() { - return this.get('model.measurements.length') > 0; - }.property('model.measurements'), - - fetchCharacteristics: function() { - if (this.get('canEdit')) { - this.store.findAll('characteristic'); - } - }.on('didInsertElement'), + // Passed in + strain: null, + allCharacteristics: null, + canEdit: false, + canAdd: false, + "add-characteristic": null, + // Properties sortParams: ['characteristic.characteristicTypeName', 'characteristic.sortOrder', 'characteristic.characteristicName'], sortAsc: true, paramsChanged: false, - sortedMeasurements: Ember.computed.sort('model.measurements', 'sortParams'), + sortedMeasurements: sort('strain.measurements', 'sortParams'), + measurementsPresent: computed('strain.measurements', function() { + return this.get('strain.measurements.length') > 0; + }), + + // TODO: remove this + // fetchCharacteristics: function() { + // if (this.get('canEdit')) { + // this.store.findAll('characteristic'); + // } + // }.on('didInsertElement'), actions: { addCharacteristic: function() { - const c = this.store.createRecord('characteristic', { - sortOrder: -999 - }); - const m = this.store.createRecord('measurement', { - characteristic: c - }); - this.get('model.measurements').addObject(m); + const newChar = this.attrs['add-characteristic'](); + this.get('strain.measurements').addObject(newChar); }, changeSortParam: function(col) { - let sort = this.get('sortAsc') ? 'asc' : 'desc'; - let sortCol = `${col}:${sort}`; - this.set('sortParams', [sortCol]); + const sort = this.get('sortAsc') ? 'asc' : 'desc'; + this.set('sortParams', [`${col}:${sort}`]); this.set('paramsChanged', true); this.toggleProperty('sortAsc'); - return false; }, resetSortParam: function() { this.set('sortParams', ['characteristic.characteristicTypeName', 'characteristic.sortOrder', 'characteristic.characteristicName']); this.set('paramsChanged', false); this.set('sortAsc', true); - return false; }, }, diff --git a/app/pods/protected/strains/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs index 25b0c27..3f635f1 100644 --- a/app/pods/protected/strains/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -1,17 +1,17 @@ {{#if canAdd}} -
- -

+
+ +

{{/if}} {{#if measurementsPresent}} -{{#if paramsChanged}} - -{{/if}} + {{#if paramsChanged}} + + {{/if}} {{#if canEdit}} diff --git a/app/pods/protected/strains/show/strain-card/template.hbs b/app/pods/protected/strains/show/strain-card/template.hbs index 86e281f..995326a 100644 --- a/app/pods/protected/strains/show/strain-card/template.hbs +++ b/app/pods/protected/strains/show/strain-card/template.hbs @@ -75,7 +75,7 @@
{{ protected/strains/measurements-table - model=strain + strain=strain canEdit=false canAdd=false }} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index b5544f3..11ef764 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -14,6 +14,7 @@ export default Component.extend(SetupMetaData, { "on-save": null, "on-cancel": null, "on-update": null, + "add-characteristic": null, // Property mapping propertiesList: ['strainName', 'typeStrain', 'species', 'isolatedFrom', 'accessionNumbers', 'genbank', 'wholeGenomeSequence', 'notes'], @@ -54,6 +55,10 @@ export default Component.extend(SetupMetaData, { return this.attrs['on-cancel'](); }, + addCharacteristic: function() { + return this.attrs['add-characteristic'](); + }, + strainNameDidChange: function(value) { this.updateField('strainName', value); }, diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index 908020f..21e5bcf 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -52,9 +52,10 @@
{{ protected/strains/measurements-table - model=strain + strain=strain + add-characteristic=(action "addCharacteristic") canEdit=strain.canEdit - canAdd=canAdd + canAdd=metaData.canAdd }}

From ba15af411ee2f674cfe6c340f495519bd0ad8453 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 15:49:55 -0700 Subject: [PATCH 08/14] Stop loading chars in measurements-table --- app/pods/protected/strains/edit/route.js | 2 ++ app/pods/protected/strains/edit/template.hbs | 1 + .../strains/measurements-table-row/component.js | 2 -- .../strains/measurements-table-row/template.hbs | 2 +- .../protected/strains/measurements-table/component.js | 9 ++------- .../protected/strains/measurements-table/template.hbs | 1 + app/pods/protected/strains/strain-form/component.js | 1 + app/pods/protected/strains/strain-form/template.hbs | 1 + 8 files changed, 9 insertions(+), 10 deletions(-) diff --git a/app/pods/protected/strains/edit/route.js b/app/pods/protected/strains/edit/route.js index 7efe43d..f8d8619 100644 --- a/app/pods/protected/strains/edit/route.js +++ b/app/pods/protected/strains/edit/route.js @@ -12,6 +12,7 @@ export default Route.extend(ElevatedAccess, { return Ember.RSVP.hash({ strain: this.store.findRecord('strain', params.strain_id), species: this.store.findAll('species'), // Need for dropdown + characteristics: this.store.findAll('characteristic'), // Need for dropdown }); }, @@ -26,6 +27,7 @@ export default Route.extend(ElevatedAccess, { setupController: function(controller, models) { controller.set('model', models.strain); controller.set('speciesList', models.species); + controller.set('allCharacteristics', models.characteristics); }, actions: { diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index c36aa54..727510c 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -3,6 +3,7 @@ strain=model speciesList=speciesList add-characteristic=(action "addCharacteristic") + allCharacteristics=allCharacteristics on-save=(action "save") on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index c6983d7..8c265bc 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -20,8 +20,6 @@ export default Component.extend({ actions: { edit: function() { - // The parent table fetches all of the characteristics ahead of time - this.set('characteristics', this.store.peekAll('characteristic')); this.toggleProperty('isEditing'); }, diff --git a/app/pods/protected/strains/measurements-table-row/template.hbs b/app/pods/protected/strains/measurements-table-row/template.hbs index a26fef4..61a7140 100644 --- a/app/pods/protected/strains/measurements-table-row/template.hbs +++ b/app/pods/protected/strains/measurements-table-row/template.hbs @@ -4,7 +4,7 @@ {{ select-2 multiple=false - content=characteristics + content=allCharacteristics value=row.characteristic optionLabelPath="characteristicName" }} diff --git a/app/pods/protected/strains/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js index a83e25e..497dd39 100644 --- a/app/pods/protected/strains/measurements-table/component.js +++ b/app/pods/protected/strains/measurements-table/component.js @@ -9,6 +9,8 @@ export default Component.extend({ allCharacteristics: null, canEdit: false, canAdd: false, + + // Actions "add-characteristic": null, // Properties @@ -20,13 +22,6 @@ export default Component.extend({ return this.get('strain.measurements.length') > 0; }), - // TODO: remove this - // fetchCharacteristics: function() { - // if (this.get('canEdit')) { - // this.store.findAll('characteristic'); - // } - // }.on('didInsertElement'), - actions: { addCharacteristic: function() { const newChar = this.attrs['add-characteristic'](); diff --git a/app/pods/protected/strains/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs index 3f635f1..288421e 100644 --- a/app/pods/protected/strains/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -43,6 +43,7 @@ {{ protected/strains/measurements-table-row row=measurement + allCharacteristics=allCharacteristics canEdit=canEdit }} {{/each}} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index 11ef764..b224aef 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -9,6 +9,7 @@ export default Component.extend(SetupMetaData, { isNew: null, isDirty: false, speciesList: null, + allCharacteristics: null, // Actions "on-save": null, diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index 21e5bcf..0200ea7 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -54,6 +54,7 @@ protected/strains/measurements-table strain=strain add-characteristic=(action "addCharacteristic") + allCharacteristics=allCharacteristics canEdit=strain.canEdit canAdd=metaData.canAdd }} From 15474c76f39e65a628fc88998e7c1998b4311023 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 15:55:52 -0700 Subject: [PATCH 09/14] Rename row -> measurement --- .../measurements-table-row/component.js | 19 ++++++++++--------- .../measurements-table-row/template.hbs | 16 ++++++++-------- .../strains/measurements-table/template.hbs | 2 +- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index 8c265bc..62bf56f 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -1,21 +1,22 @@ import Ember from 'ember'; import ajaxError from '../../../../utils/ajax-error'; -const { Component } = Ember; +const { Component, computed } = Ember; export default Component.extend({ tagName: 'tr', isEditing: false, allCharacteristics: null, + measurement: null, oldCharacteristicId: function() { - let json = this.get('row').toJSON(); + let json = this.get('measurement').toJSON(); return json.characteristic; }.property(), - rowChanged: Ember.computed('row.notes', 'row.value', 'row.characteristic.id', function() { - return this.get('row.hasDirtyAttributes') || - this.get('oldCharacteristicId') !== this.get('row.characteristic.id'); + rowChanged: computed('measurement.notes', 'measurement.value', 'measurement.characteristic.id', function() { + return this.get('measurement.hasDirtyAttributes') || + this.get('oldCharacteristicId') !== this.get('measurement.characteristic.id'); }), actions: { @@ -25,11 +26,11 @@ export default Component.extend({ save: function() { if (this.get('rowChanged')) { - this.get('row').save().then(() => { + this.get('measurement').save().then(() => { this.get('flashMessages').clearMessages(); this.toggleProperty('isEditing'); }, () => { - ajaxError(this.get('row.errors'), this.get('flashMessages')); + ajaxError(this.get('measurement.errors'), this.get('flashMessages')); }); } else { this.toggleProperty('isEditing'); @@ -37,11 +38,11 @@ export default Component.extend({ }, delete: function() { - let char = this.get('row.characteristic'); + let char = this.get('measurement.characteristic'); if (char.get('isNew')) { char.destroyRecord(); } - this.get('row').destroyRecord(); + this.get('measurement').destroyRecord(); } }, diff --git a/app/pods/protected/strains/measurements-table-row/template.hbs b/app/pods/protected/strains/measurements-table-row/template.hbs index 61a7140..cab5554 100644 --- a/app/pods/protected/strains/measurements-table-row/template.hbs +++ b/app/pods/protected/strains/measurements-table-row/template.hbs @@ -5,15 +5,15 @@ select-2 multiple=false content=allCharacteristics - value=row.characteristic + value=measurement.characteristic optionLabelPath="characteristicName" }}
{{#if canEdit}} {{#if canEdit}} {{#if canEdit}}
- {{input value=row.value}} + {{input value=measurement.value}} - {{input value=row.notes}} + {{input value=measurement.notes}} @@ -30,18 +30,18 @@ {{/if}} {{else}} - {{{row.characteristic.characteristicTypeName}}} + {{{measurement.characteristic.characteristicTypeName}}} - {{#link-to 'protected.characteristics.show' row.characteristic.id}} - {{{row.characteristic.characteristicName}}} + {{#link-to 'protected.characteristics.show' measurement.characteristic.id}} + {{{measurement.characteristic.characteristicName}}} {{/link-to}} - {{row.value}} + {{measurement.value}} - {{row.notes}} + {{measurement.notes}} diff --git a/app/pods/protected/strains/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs index 288421e..146d44e 100644 --- a/app/pods/protected/strains/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -42,7 +42,7 @@ {{#each sortedMeasurements as |measurement|}} {{ protected/strains/measurements-table-row - row=measurement + measurement=measurement allCharacteristics=allCharacteristics canEdit=canEdit }} From b2fa171d1776364fd29f89b452f511531d7610ce Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 16:08:40 -0700 Subject: [PATCH 10/14] Save measurement --- app/pods/protected/strains/edit/controller.js | 10 ++++++++++ app/pods/protected/strains/edit/template.hbs | 1 + .../strains/measurements-table-row/component.js | 13 ++----------- .../strains/measurements-table/component.js | 5 +++++ .../strains/measurements-table/template.hbs | 1 + app/pods/protected/strains/strain-form/component.js | 5 +++++ app/pods/protected/strains/strain-form/template.hbs | 1 + 7 files changed, 25 insertions(+), 11 deletions(-) diff --git a/app/pods/protected/strains/edit/controller.js b/app/pods/protected/strains/edit/controller.js index d3640c7..0bc7bc0 100644 --- a/app/pods/protected/strains/edit/controller.js +++ b/app/pods/protected/strains/edit/controller.js @@ -1,5 +1,6 @@ import Ember from 'ember'; import SaveModel from '../../../../mixins/save-model'; +import ajaxError from '../../../../utils/ajax-error'; const { Controller } = Ember; @@ -14,5 +15,14 @@ export default Controller.extend(SaveModel, { characteristic: this.store.createRecord('characteristic', { sortOrder: -999 }), }); }, + + saveMeasurement: function(measurement) { + measurement.save().then(() => { + this.get('flashMessages').clearMessages(); + }, () => { + ajaxError(measurement.get('errors'), this.get('flashMessages')); + }); + }, + }, }); diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index 727510c..f252090 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -4,6 +4,7 @@ speciesList=speciesList add-characteristic=(action "addCharacteristic") allCharacteristics=allCharacteristics + save-measurement=(action "saveMeasurement") on-save=(action "save") on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index 62bf56f..0c7f96c 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -1,5 +1,4 @@ import Ember from 'ember'; -import ajaxError from '../../../../utils/ajax-error'; const { Component, computed } = Ember; @@ -25,16 +24,8 @@ export default Component.extend({ }, save: function() { - if (this.get('rowChanged')) { - this.get('measurement').save().then(() => { - this.get('flashMessages').clearMessages(); - this.toggleProperty('isEditing'); - }, () => { - ajaxError(this.get('measurement.errors'), this.get('flashMessages')); - }); - } else { - this.toggleProperty('isEditing'); - } + this.attrs['save-measurement'](this.get('measurement')); + this.toggleProperty('isEditing'); }, delete: function() { diff --git a/app/pods/protected/strains/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js index 497dd39..a797815 100644 --- a/app/pods/protected/strains/measurements-table/component.js +++ b/app/pods/protected/strains/measurements-table/component.js @@ -12,6 +12,7 @@ export default Component.extend({ // Actions "add-characteristic": null, + "save-measurement": null, // Properties sortParams: ['characteristic.characteristicTypeName', 'characteristic.sortOrder', 'characteristic.characteristicName'], @@ -40,6 +41,10 @@ export default Component.extend({ this.set('paramsChanged', false); this.set('sortAsc', true); }, + + saveMeasurement: function(measurement) { + return this.attrs['save-measurement'](measurement); + }, }, }); diff --git a/app/pods/protected/strains/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs index 146d44e..5a813d7 100644 --- a/app/pods/protected/strains/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -43,6 +43,7 @@ {{ protected/strains/measurements-table-row measurement=measurement + save-measurement=(action "saveMeasurement") allCharacteristics=allCharacteristics canEdit=canEdit }} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index b224aef..c291343 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -16,6 +16,7 @@ export default Component.extend(SetupMetaData, { "on-cancel": null, "on-update": null, "add-characteristic": null, + "save-measurement": null, // Property mapping propertiesList: ['strainName', 'typeStrain', 'species', 'isolatedFrom', 'accessionNumbers', 'genbank', 'wholeGenomeSequence', 'notes'], @@ -60,6 +61,10 @@ export default Component.extend(SetupMetaData, { return this.attrs['add-characteristic'](); }, + saveMeasurement: function(measurement) { + return this.attrs['save-measurement'](measurement); + }, + strainNameDidChange: function(value) { this.updateField('strainName', value); }, diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index 0200ea7..9999954 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -55,6 +55,7 @@ strain=strain add-characteristic=(action "addCharacteristic") allCharacteristics=allCharacteristics + save-measurement=(action "saveMeasurement") canEdit=strain.canEdit canAdd=metaData.canAdd }} From c1ff0d57b46cec89379001c9caa141effa147ba8 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 16:14:02 -0700 Subject: [PATCH 11/14] Delete measurement --- app/pods/protected/strains/edit/controller.js | 8 ++++++++ app/pods/protected/strains/edit/template.hbs | 1 + .../strains/measurements-table-row/component.js | 14 +++++++------- .../strains/measurements-table/component.js | 5 +++++ .../strains/measurements-table/template.hbs | 1 + .../protected/strains/strain-form/component.js | 5 +++++ .../protected/strains/strain-form/template.hbs | 1 + 7 files changed, 28 insertions(+), 7 deletions(-) diff --git a/app/pods/protected/strains/edit/controller.js b/app/pods/protected/strains/edit/controller.js index 0bc7bc0..17f47d6 100644 --- a/app/pods/protected/strains/edit/controller.js +++ b/app/pods/protected/strains/edit/controller.js @@ -24,5 +24,13 @@ export default Controller.extend(SaveModel, { }); }, + deleteMeasurement: function(measurement) { + const characteristic = measurement.get('characteristic'); + if (characteristic.get('isNew')) { + characteristic.destroyRecord(); + } + measurement.destroyRecord(); + }, + }, }); diff --git a/app/pods/protected/strains/edit/template.hbs b/app/pods/protected/strains/edit/template.hbs index f252090..59d1633 100644 --- a/app/pods/protected/strains/edit/template.hbs +++ b/app/pods/protected/strains/edit/template.hbs @@ -5,6 +5,7 @@ add-characteristic=(action "addCharacteristic") allCharacteristics=allCharacteristics save-measurement=(action "saveMeasurement") + delete-measurement=(action "deleteMeasurement") on-save=(action "save") on-cancel=(action "cancel") }} diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index 0c7f96c..cba52a6 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -8,8 +8,12 @@ export default Component.extend({ allCharacteristics: null, measurement: null, + // Actions + "save-measurement": null, + "delete-measurement": null, + oldCharacteristicId: function() { - let json = this.get('measurement').toJSON(); + const json = this.get('measurement').toJSON(); return json.characteristic; }.property(), @@ -29,12 +33,8 @@ export default Component.extend({ }, delete: function() { - let char = this.get('measurement.characteristic'); - if (char.get('isNew')) { - char.destroyRecord(); - } - this.get('measurement').destroyRecord(); - } + this.attrs['delete-measurement'](this.get('measurement')); + }, }, }); diff --git a/app/pods/protected/strains/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js index a797815..ab0b72e 100644 --- a/app/pods/protected/strains/measurements-table/component.js +++ b/app/pods/protected/strains/measurements-table/component.js @@ -13,6 +13,7 @@ export default Component.extend({ // Actions "add-characteristic": null, "save-measurement": null, + "delete-measurement": null, // Properties sortParams: ['characteristic.characteristicTypeName', 'characteristic.sortOrder', 'characteristic.characteristicName'], @@ -45,6 +46,10 @@ export default Component.extend({ saveMeasurement: function(measurement) { return this.attrs['save-measurement'](measurement); }, + + deleteMeasurement: function(measurement) { + return this.attrs['delete-measurement'](measurement); + }, }, }); diff --git a/app/pods/protected/strains/measurements-table/template.hbs b/app/pods/protected/strains/measurements-table/template.hbs index 5a813d7..9e22393 100644 --- a/app/pods/protected/strains/measurements-table/template.hbs +++ b/app/pods/protected/strains/measurements-table/template.hbs @@ -44,6 +44,7 @@ protected/strains/measurements-table-row measurement=measurement save-measurement=(action "saveMeasurement") + delete-measurement=(action "deleteMeasurement") allCharacteristics=allCharacteristics canEdit=canEdit }} diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index c291343..be823bc 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -17,6 +17,7 @@ export default Component.extend(SetupMetaData, { "on-update": null, "add-characteristic": null, "save-measurement": null, + "delete-measurement": null, // Property mapping propertiesList: ['strainName', 'typeStrain', 'species', 'isolatedFrom', 'accessionNumbers', 'genbank', 'wholeGenomeSequence', 'notes'], @@ -65,6 +66,10 @@ export default Component.extend(SetupMetaData, { return this.attrs['save-measurement'](measurement); }, + deleteMeasurement: function(measurement) { + return this.attrs['delete-measurement'](measurement); + }, + strainNameDidChange: function(value) { this.updateField('strainName', value); }, diff --git a/app/pods/protected/strains/strain-form/template.hbs b/app/pods/protected/strains/strain-form/template.hbs index 9999954..47c5112 100644 --- a/app/pods/protected/strains/strain-form/template.hbs +++ b/app/pods/protected/strains/strain-form/template.hbs @@ -56,6 +56,7 @@ add-characteristic=(action "addCharacteristic") allCharacteristics=allCharacteristics save-measurement=(action "saveMeasurement") + delete-measurement=(action "deleteMeasurement") canEdit=strain.canEdit canAdd=metaData.canAdd }} From 1ee0e0e5ed80707035a7abbee2295582f0cfdfc9 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 21:21:59 -0700 Subject: [PATCH 12/14] DDAU (WIP) --- app/pods/protected/strains/edit/controller.js | 3 +- .../measurements-table-row/component.js | 44 +++++++++++++++---- .../measurements-table-row/template.hbs | 8 ++-- .../strains/measurements-table/component.js | 4 +- .../strains/strain-form/component.js | 4 +- 5 files changed, 46 insertions(+), 17 deletions(-) diff --git a/app/pods/protected/strains/edit/controller.js b/app/pods/protected/strains/edit/controller.js index 17f47d6..4d68665 100644 --- a/app/pods/protected/strains/edit/controller.js +++ b/app/pods/protected/strains/edit/controller.js @@ -16,7 +16,8 @@ export default Controller.extend(SaveModel, { }); }, - saveMeasurement: function(measurement) { + saveMeasurement: function(measurement, properties) { + measurement.setProperties(properties); measurement.save().then(() => { this.get('flashMessages').clearMessages(); }, () => { diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index cba52a6..b818de6 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -4,31 +4,47 @@ const { Component, computed } = Ember; export default Component.extend({ tagName: 'tr', + + // Read-only attributes isEditing: false, allCharacteristics: null, measurement: null, + isDirty: null, // Actions "save-measurement": null, "delete-measurement": null, - oldCharacteristicId: function() { - const json = this.get('measurement').toJSON(); - return json.characteristic; - }.property(), + // Property mapping + propertiesList: ['characteristic', 'value', 'notes'], + characteristic: null, + value: null, + notes: null, - rowChanged: computed('measurement.notes', 'measurement.value', 'measurement.characteristic.id', function() { - return this.get('measurement.hasDirtyAttributes') || - this.get('oldCharacteristicId') !== this.get('measurement.characteristic.id'); + resetOnInit: Ember.on('init', function() { + this.get('propertiesList').forEach((field) => { + const valueInMeasurement = this.get('measurement').get(field); + this.set(field, valueInMeasurement); + }); }), + updateField: function(property, value) { + this.set(property, value); + // Manually compare against passed in value + if (this.get('measurement').get(property) !== value) { + this.set('isDirty', true); + } else { + this.set('isDirty', false); + } + }, + actions: { edit: function() { this.toggleProperty('isEditing'); }, save: function() { - this.attrs['save-measurement'](this.get('measurement')); + this.attrs['save-measurement'](this.get('measurement'), this.getProperties(this.get('propertiesList'))); this.toggleProperty('isEditing'); }, @@ -36,5 +52,17 @@ export default Component.extend({ this.attrs['delete-measurement'](this.get('measurement')); }, + characteristicDidChange: function(value) { + this.updateField('characteristic', value); + }, + + valueDidChange: function(value) { + this.updateField('value', value); + }, + + notesDidChange: function(value) { + this.updateField('notes', value); + }, + }, }); diff --git a/app/pods/protected/strains/measurements-table-row/template.hbs b/app/pods/protected/strains/measurements-table-row/template.hbs index cab5554..5bb44f0 100644 --- a/app/pods/protected/strains/measurements-table-row/template.hbs +++ b/app/pods/protected/strains/measurements-table-row/template.hbs @@ -5,19 +5,19 @@ select-2 multiple=false content=allCharacteristics - value=measurement.characteristic + value=characteristic optionLabelPath="characteristicName" }} - {{input value=measurement.value}} + {{one-way-input type="text" class="measurement-value" value=value update=(action "valueDidChange")}} - {{input value=measurement.notes}} + {{one-way-input type="text" class="measurement-notes" value=notes update=(action "notesDidChange")}} - {{#if rowChanged}} + {{#if isDirty}} diff --git a/app/pods/protected/strains/measurements-table/component.js b/app/pods/protected/strains/measurements-table/component.js index ab0b72e..e4fd3a1 100644 --- a/app/pods/protected/strains/measurements-table/component.js +++ b/app/pods/protected/strains/measurements-table/component.js @@ -43,8 +43,8 @@ export default Component.extend({ this.set('sortAsc', true); }, - saveMeasurement: function(measurement) { - return this.attrs['save-measurement'](measurement); + saveMeasurement: function(measurement, properties) { + return this.attrs['save-measurement'](measurement, properties); }, deleteMeasurement: function(measurement) { diff --git a/app/pods/protected/strains/strain-form/component.js b/app/pods/protected/strains/strain-form/component.js index be823bc..420db5f 100644 --- a/app/pods/protected/strains/strain-form/component.js +++ b/app/pods/protected/strains/strain-form/component.js @@ -62,8 +62,8 @@ export default Component.extend(SetupMetaData, { return this.attrs['add-characteristic'](); }, - saveMeasurement: function(measurement) { - return this.attrs['save-measurement'](measurement); + saveMeasurement: function(measurement, properties) { + return this.attrs['save-measurement'](measurement, properties); }, deleteMeasurement: function(measurement) { From d46b3fc48be4e5858d26307b33da9c65776e7aa0 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Tue, 10 Nov 2015 21:32:49 -0700 Subject: [PATCH 13/14] Dropping select 2 for now --- .../strains/measurements-table-row/component.js | 3 ++- .../strains/measurements-table-row/template.hbs | 12 +++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index b818de6..c3e5c89 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -53,7 +53,8 @@ export default Component.extend({ }, characteristicDidChange: function(value) { - this.updateField('characteristic', value); + const newCharacteristic = this.get('allCharacteristics').findBy('id', value); + this.updateField('characteristic', newCharacteristic); }, valueDidChange: function(value) { diff --git a/app/pods/protected/strains/measurements-table-row/template.hbs b/app/pods/protected/strains/measurements-table-row/template.hbs index 5bb44f0..0dc03b7 100644 --- a/app/pods/protected/strains/measurements-table-row/template.hbs +++ b/app/pods/protected/strains/measurements-table-row/template.hbs @@ -1,13 +1,11 @@ {{#if isEditing}} - {{ - select-2 - multiple=false - content=allCharacteristics - value=characteristic - optionLabelPath="characteristicName" - }} + {{one-way-input type="text" class="measurement-value" value=value update=(action "valueDidChange")}} From 90deef228bf18e5290b34c3053d692551cbea44d Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Wed, 11 Nov 2015 11:52:52 -0700 Subject: [PATCH 14/14] Linting --- app/pods/protected/strains/measurements-table-row/component.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pods/protected/strains/measurements-table-row/component.js b/app/pods/protected/strains/measurements-table-row/component.js index c3e5c89..ad63dc9 100644 --- a/app/pods/protected/strains/measurements-table-row/component.js +++ b/app/pods/protected/strains/measurements-table-row/component.js @@ -1,6 +1,6 @@ import Ember from 'ember'; -const { Component, computed } = Ember; +const { Component } = Ember; export default Component.extend({ tagName: 'tr',