From 140d4efd1e47366519cb21fa0c4145feb4a389bb Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:22:34 -0800 Subject: [PATCH 01/10] Remove console log stmt --- app/pods/components/measurement-search-table/component.js | 1 - 1 file changed, 1 deletion(-) diff --git a/app/pods/components/measurement-search-table/component.js b/app/pods/components/measurement-search-table/component.js index 693dd17..0a941ee 100644 --- a/app/pods/components/measurement-search-table/component.js +++ b/app/pods/components/measurement-search-table/component.js @@ -12,7 +12,6 @@ export default Ember.Component.extend({ this.set('measurements', measurements); }); this.set('isLoading', false); - console.log(this.get('isLoading')); return false; } let search = {}; From 92d55265b2eb8e53b483bf6fae43eec8cfb58203 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:23:04 -0800 Subject: [PATCH 02/10] Remove scientific-name component --- .../components/scientific-name/component.js | 6 ------ .../components/scientific-name/template.hbs | 1 - tests/unit/components/scientific-name-test.js | 21 ------------------- 3 files changed, 28 deletions(-) delete mode 100644 app/pods/components/scientific-name/component.js delete mode 100644 app/pods/components/scientific-name/template.hbs delete mode 100644 tests/unit/components/scientific-name-test.js diff --git a/app/pods/components/scientific-name/component.js b/app/pods/components/scientific-name/component.js deleted file mode 100644 index 40bf39c..0000000 --- a/app/pods/components/scientific-name/component.js +++ /dev/null @@ -1,6 +0,0 @@ -import Ember from 'ember'; - -export default Ember.Component.extend({ - tagName: 'span', - strain: null, // passed in -}); diff --git a/app/pods/components/scientific-name/template.hbs b/app/pods/components/scientific-name/template.hbs deleted file mode 100644 index 1f3609e..0000000 --- a/app/pods/components/scientific-name/template.hbs +++ /dev/null @@ -1 +0,0 @@ -{{strain.species.speciesName}} (strain {{strain-name strain=strain}}) diff --git a/tests/unit/components/scientific-name-test.js b/tests/unit/components/scientific-name-test.js deleted file mode 100644 index b6a7957..0000000 --- a/tests/unit/components/scientific-name-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('scientific-name', { - // specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); From ab2a1691142959cbe124988b1c071e2020832b90 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:23:18 -0800 Subject: [PATCH 03/10] Remove mesa-index-row component --- app/pods/components/measurement-index-row/component.js | 5 ----- app/pods/components/measurement-index-row/template.hbs | 9 --------- 2 files changed, 14 deletions(-) delete mode 100644 app/pods/components/measurement-index-row/component.js delete mode 100644 app/pods/components/measurement-index-row/template.hbs diff --git a/app/pods/components/measurement-index-row/component.js b/app/pods/components/measurement-index-row/component.js deleted file mode 100644 index f48ea57..0000000 --- a/app/pods/components/measurement-index-row/component.js +++ /dev/null @@ -1,5 +0,0 @@ -import Ember from 'ember'; - -export default Ember.Component.extend({ - tagName: 'tr', -}); diff --git a/app/pods/components/measurement-index-row/template.hbs b/app/pods/components/measurement-index-row/template.hbs deleted file mode 100644 index fe9a6b6..0000000 --- a/app/pods/components/measurement-index-row/template.hbs +++ /dev/null @@ -1,9 +0,0 @@ - - {{scientific-name strain=data.strain}} - - - {{data.characteristic.characteristicName}} - - - {{{data.value}}} - From 2bf7534ec4be5ec7d7cd89c5ae30a3c82c94c4f6 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:23:33 -0800 Subject: [PATCH 04/10] Try computed properties --- app/models/strain.js | 13 +++++++++---- .../measurement-search-table/template.hbs | 7 ++++++- app/pods/components/strain-index-row/template.hbs | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/app/models/strain.js b/app/models/strain.js index 12c7196..cf0fe3a 100644 --- a/app/models/strain.js +++ b/app/models/strain.js @@ -1,5 +1,4 @@ import DS from 'ember-data'; -import Ember from 'ember'; export default DS.Model.extend({ measurements: DS.hasMany('measurements', { async: true }), @@ -17,7 +16,13 @@ export default DS.Model.extend({ updatedBy: DS.attr('number'), deletedBy: DS.attr('number'), totalMeasurements: DS.attr('number'), - fullName: Ember.computed('species.speciesName', 'strainName', function() { - return this.get('species.speciesName') + ' (strain ' + this.get('strainName') + ')'; - }) + fullName: function() { + return `${this.get('species.speciesName')} (strain ${this.get('strainName')})`; + }.property('species', 'strainName').readOnly(), + fullNameMU: function() { + let species = `${this.get('species.speciesName')}`, + type = this.get('typeStrain') ? 'T' : '', + strain = `(strain ${this.get('strainName')}${type})`; + return `${species} ${strain}`; + }.property('species', 'strainName').readOnly(), }); diff --git a/app/pods/components/measurement-search-table/template.hbs b/app/pods/components/measurement-search-table/template.hbs index 667312e..93d8ab8 100644 --- a/app/pods/components/measurement-search-table/template.hbs +++ b/app/pods/components/measurement-search-table/template.hbs @@ -10,6 +10,7 @@ {{#if isLoading}} + {{!-- This doesn't work yet --}} {{loading-panel}} {{else}} @@ -22,7 +23,11 @@ {{#each measurements as |measurement|}} - {{measurement-index-row data=measurement}} + + + + + {{/each}}
{{{measurement.strain.fullNameMU}}}{{measurement.characteristic.characteristicName}}{{{measurement.value}}}
diff --git a/app/pods/components/strain-index-row/template.hbs b/app/pods/components/strain-index-row/template.hbs index 4d64b0b..f512924 100644 --- a/app/pods/components/strain-index-row/template.hbs +++ b/app/pods/components/strain-index-row/template.hbs @@ -1,6 +1,6 @@ {{#link-to 'strains.show' data.id classBinding="data.typeStrain:type-strain"}} - {{scientific-name strain=data}} + {{{data.fullNameMU}}} {{/link-to}} From 70ce1281031026ed570b246a9e09de04fe2e325a Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:24:45 -0800 Subject: [PATCH 05/10] genus-name component readonly --- app/pods/components/genus-name/component.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pods/components/genus-name/component.js b/app/pods/components/genus-name/component.js index bae8cb9..ce66e93 100644 --- a/app/pods/components/genus-name/component.js +++ b/app/pods/components/genus-name/component.js @@ -4,5 +4,5 @@ export default Ember.Component.extend({ tagName: 'em', genus: function() { return this.get('globals.genus').capitalize(); - }.property(), + }.property().readOnly(), }); From b8ae6802a5debbb46f503c8f657c0f9e0acaafdb Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 11:44:23 -0800 Subject: [PATCH 06/10] Remove strain-name component --- app/models/strain.js | 11 ++++++----- .../components/species-details/template.hbs | 2 +- .../components/species-index-row/template.hbs | 2 +- app/pods/components/strain-name/component.js | 5 ----- app/pods/components/strain-name/template.hbs | 1 - .../components/strain-name/component-test.js | 19 ------------------- 6 files changed, 8 insertions(+), 32 deletions(-) delete mode 100644 app/pods/components/strain-name/component.js delete mode 100644 app/pods/components/strain-name/template.hbs delete mode 100644 tests/unit/pods/components/strain-name/component-test.js diff --git a/app/models/strain.js b/app/models/strain.js index cf0fe3a..b5313c3 100644 --- a/app/models/strain.js +++ b/app/models/strain.js @@ -16,13 +16,14 @@ export default DS.Model.extend({ updatedBy: DS.attr('number'), deletedBy: DS.attr('number'), totalMeasurements: DS.attr('number'), + strainNameMU: function() { + let type = this.get('typeStrain') ? 'T' : ''; + return `${this.get('strainName')}${type}`; + }.property('strainName', 'typeStrain').readOnly(), fullName: function() { return `${this.get('species.speciesName')} (strain ${this.get('strainName')})`; }.property('species', 'strainName').readOnly(), fullNameMU: function() { - let species = `${this.get('species.speciesName')}`, - type = this.get('typeStrain') ? 'T' : '', - strain = `(strain ${this.get('strainName')}${type})`; - return `${species} ${strain}`; - }.property('species', 'strainName').readOnly(), + return `${this.get('species')} ${this.get('strainNameMU')}`; + }.property('species', 'strainNameMU').readOnly(), }); diff --git a/app/pods/components/species-details/template.hbs b/app/pods/components/species-details/template.hbs index 756a6a0..813ada2 100644 --- a/app/pods/components/species-details/template.hbs +++ b/app/pods/components/species-details/template.hbs @@ -18,7 +18,7 @@ {{#each species.strains as |strain index|}} {{if index ","}} {{#link-to 'strains.show' strain.id}} - {{strain-name strain=strain}} + {{{strain.strainNameMU}}} {{/link-to}} {{/each}} {{#unless species.isNew}} diff --git a/app/pods/components/species-index-row/template.hbs b/app/pods/components/species-index-row/template.hbs index e3455a7..e86113a 100644 --- a/app/pods/components/species-index-row/template.hbs +++ b/app/pods/components/species-index-row/template.hbs @@ -9,7 +9,7 @@ {{#each data.strains as |strain index|}} {{if index ","}} {{#link-to 'strains.show' strain.id}} - {{strain-name strain=strain}} + {{{strain.strainNameMU}}} {{/link-to}} {{/each}} diff --git a/app/pods/components/strain-name/component.js b/app/pods/components/strain-name/component.js deleted file mode 100644 index ced0374..0000000 --- a/app/pods/components/strain-name/component.js +++ /dev/null @@ -1,5 +0,0 @@ -import Ember from 'ember'; - -export default Ember.Component.extend({ - tagName: 'span', -}); diff --git a/app/pods/components/strain-name/template.hbs b/app/pods/components/strain-name/template.hbs deleted file mode 100644 index 3082ce7..0000000 --- a/app/pods/components/strain-name/template.hbs +++ /dev/null @@ -1 +0,0 @@ -{{strain.strainName}}{{{if strain.typeStrain 'T'}}} diff --git a/tests/unit/pods/components/strain-name/component-test.js b/tests/unit/pods/components/strain-name/component-test.js deleted file mode 100644 index 3874bf8..0000000 --- a/tests/unit/pods/components/strain-name/component-test.js +++ /dev/null @@ -1,19 +0,0 @@ -import { moduleForComponent, test } from 'ember-qunit'; - -moduleForComponent('strain-name', 'Unit | Component | strain name', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'], - unit: true -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); From 62426cff9d2ad66b943e6a05d25b31035fa44796 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 12:00:17 -0800 Subject: [PATCH 07/10] fix speciesname in fullname --- app/models/strain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/strain.js b/app/models/strain.js index b5313c3..8a46bfd 100644 --- a/app/models/strain.js +++ b/app/models/strain.js @@ -24,6 +24,6 @@ export default DS.Model.extend({ return `${this.get('species.speciesName')} (strain ${this.get('strainName')})`; }.property('species', 'strainName').readOnly(), fullNameMU: function() { - return `${this.get('species')} ${this.get('strainNameMU')}`; + return `${this.get('species.speciesName')} ${this.get('strainNameMU')}`; }.property('species', 'strainNameMU').readOnly(), }); From a354ecd639996d16e51b043ee5f88f30a34ba8ee Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 12:40:28 -0800 Subject: [PATCH 08/10] Clean up meas search a bit --- app/pods/components/measurement-search-table/component.js | 7 +------ app/pods/components/measurement-search-table/template.hbs | 2 +- app/pods/measurements/route.js | 7 ------- app/pods/measurements/template.hbs | 6 +++++- 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/app/pods/components/measurement-search-table/component.js b/app/pods/components/measurement-search-table/component.js index 0a941ee..2d618ef 100644 --- a/app/pods/components/measurement-search-table/component.js +++ b/app/pods/components/measurement-search-table/component.js @@ -1,18 +1,15 @@ import Ember from 'ember'; export default Ember.Component.extend({ - isLoading: false, actions: { search: function() { - this.set('isLoading', true); let strain = this.get('selectedStrain'); let characteristic = this.get('selectedCharacteristic'); if ((strain === 'all') && (characteristic === 'all')) { this.store.findAll('measurement').then((measurements)=>{ this.set('measurements', measurements); }); - this.set('isLoading', false); - return false; + return; } let search = {}; if (strain !== 'all') { @@ -24,8 +21,6 @@ export default Ember.Component.extend({ this.store.find('measurement', search).then((measurements)=>{ this.set('measurements', measurements); }); - this.set('isLoading', false); - return false; } }, }); diff --git a/app/pods/components/measurement-search-table/template.hbs b/app/pods/components/measurement-search-table/template.hbs index 93d8ab8..601ad48 100644 --- a/app/pods/components/measurement-search-table/template.hbs +++ b/app/pods/components/measurement-search-table/template.hbs @@ -10,7 +10,7 @@ {{#if isLoading}} - {{!-- This doesn't work yet --}} + {{!-- This doesn't work yet, something is blocking --}} {{loading-panel}} {{else}} diff --git a/app/pods/measurements/route.js b/app/pods/measurements/route.js index 9dbfd63..1b8e793 100644 --- a/app/pods/measurements/route.js +++ b/app/pods/measurements/route.js @@ -10,13 +10,6 @@ export default Ember.Route.extend(AuthenticatedRouteMixin, { }); }, setupController: function(controller, models) { - var tableAttrs = [ - { name: 'Strain', attr: 'strain.strainName' }, - { name: 'Characteristic', attr: 'characteristic.characteristicName' }, - { name: 'Value', attr: 'computedValue'} - ]; - controller.set('tableAttrs', tableAttrs); - controller.set('row', 'measurement-index-row'); controller.set('measurements', []); // Set up search parameters diff --git a/app/pods/measurements/template.hbs b/app/pods/measurements/template.hbs index 87b6327..e99f3e2 100644 --- a/app/pods/measurements/template.hbs +++ b/app/pods/measurements/template.hbs @@ -28,4 +28,8 @@ -{{measurement-search-table}} +{{ + measurement-search-table + selectedStrain=selectedStrain + selectedCharacteristic=selectedCharacteristic +}} From 046fea2dbb2ad127089bf39cc13f07f32caf4b35 Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 14:46:38 -0800 Subject: [PATCH 09/10] select2 --- app/pods/measurements/route.js | 16 ++++++++-------- app/pods/measurements/template.hbs | 16 +++++++++------- bower.json | 3 ++- config/environment.js | 2 +- package.json | 1 + 5 files changed, 21 insertions(+), 17 deletions(-) diff --git a/app/pods/measurements/route.js b/app/pods/measurements/route.js index 1b8e793..9c45e22 100644 --- a/app/pods/measurements/route.js +++ b/app/pods/measurements/route.js @@ -16,26 +16,26 @@ export default Ember.Route.extend(AuthenticatedRouteMixin, { models.strains = models.strains.sortBy('fullName'); let strains = models.strains.map((strain)=>{ return Ember.Object.create({ - val: strain.get('id'), - lab: strain.get('fullName'), + id: strain.get('id'), + text: strain.get('fullName'), }); }); strains.unshiftObjects(Ember.Object.create({ - val: 'all', - lab: 'All Strains', + id: 'all', + text: 'All Strains', })); controller.set('strains', strains); models.characteristics = models.characteristics.sortBy('characteristicName'); let characteristics = models.characteristics.map((characteristic)=>{ return Ember.Object.create({ - val: characteristic.get('id'), - lab: characteristic.get('characteristicName'), + id: characteristic.get('id'), + text: characteristic.get('characteristicName'), }); }); characteristics.unshiftObjects(Ember.Object.create({ - val: 'all', - lab: 'All Characteristics', + id: 'all', + text: 'All Characteristics', })); controller.set('characteristics', characteristics); }, diff --git a/app/pods/measurements/template.hbs b/app/pods/measurements/template.hbs index e99f3e2..882fce6 100644 --- a/app/pods/measurements/template.hbs +++ b/app/pods/measurements/template.hbs @@ -5,11 +5,12 @@
{{ - view "select" + select-2 + multiple=true content=strains - optionValuePath="content.val" - optionLabelPath="content.lab" - value=selectedStrain + value=selectedStrains + optionValuePath="id" + placeholder="Choose a strain" }}
@@ -19,11 +20,12 @@
{{ - view "select" + select-2 + multiple=true content=characteristics - optionValuePath="content.val" - optionLabelPath="content.lab" value=selectedCharacteristic + optionValuePath="id" + placeholder="Choose a characteristic" }}
diff --git a/bower.json b/bower.json index bb963a8..6b573d8 100644 --- a/bower.json +++ b/bower.json @@ -14,6 +14,7 @@ "qunit": "~1.17.1", "flakes": "~1.0.0", "ember-simple-auth": "~0.8.0-beta.3", - "moment": "~2.9.0" + "moment": "~2.9.0", + "select2": "3.5.2" } } diff --git a/config/environment.js b/config/environment.js index c1ece05..3ce0d37 100644 --- a/config/environment.js +++ b/config/environment.js @@ -41,7 +41,7 @@ module.exports = function(environment) { 'font-src': "'self'", 'connect-src': "'self' http://127.0.0.1:4200", 'img-src': "'self'", - 'style-src': "'self'", + 'style-src': "'self' 'unsafe-inline'", 'media-src': "'self'" } } diff --git a/package.json b/package.json index 1dcc597..d2dc24b 100644 --- a/package.json +++ b/package.json @@ -37,6 +37,7 @@ "ember-data": "1.0.0-beta.18", "ember-disable-proxy-controllers": "^1.0.0", "ember-export-application-global": "^1.0.2", + "ember-select-2": "1.3.0", "express": "^4.12.4", "glob": "^4.5.3", "jsonwebtoken": "^5.0.0", From 33d325a4b0d2c20deb70864bafe7fe7e807ee2ee Mon Sep 17 00:00:00 2001 From: Matthew Dillon Date: Fri, 12 Jun 2015 15:30:05 -0800 Subject: [PATCH 10/10] cleaning up measurements table --- .../measurement-search-table/component.js | 26 ------ .../measurement-search-table/template.hbs | 34 ------- app/pods/measurements/controller.js | 15 ++++ app/pods/measurements/route.js | 39 +++----- app/pods/measurements/template.hbs | 90 ++++++++++++------- app/styles/app.css | 4 + tests/unit/components/display-error-test.js | 21 ----- tests/unit/components/genus-name-test.js | 21 ----- .../measurements/measurement-row-test.js | 21 ----- .../species/species-details-test.js | 21 ----- .../components/strains/strain-details-test.js | 21 ----- .../measurement-index-row/component-test.js | 18 ---- .../component-test.js | 19 ---- .../unit/pods/measurements/controller-test.js | 12 +++ 14 files changed, 102 insertions(+), 260 deletions(-) delete mode 100644 app/pods/components/measurement-search-table/component.js delete mode 100644 app/pods/components/measurement-search-table/template.hbs create mode 100644 app/pods/measurements/controller.js delete mode 100644 tests/unit/components/display-error-test.js delete mode 100644 tests/unit/components/genus-name-test.js delete mode 100644 tests/unit/components/measurements/measurement-row-test.js delete mode 100644 tests/unit/components/species/species-details-test.js delete mode 100644 tests/unit/components/strains/strain-details-test.js delete mode 100644 tests/unit/pods/components/measurement-index-row/component-test.js delete mode 100644 tests/unit/pods/components/measurement-search-table/component-test.js create mode 100644 tests/unit/pods/measurements/controller-test.js diff --git a/app/pods/components/measurement-search-table/component.js b/app/pods/components/measurement-search-table/component.js deleted file mode 100644 index 2d618ef..0000000 --- a/app/pods/components/measurement-search-table/component.js +++ /dev/null @@ -1,26 +0,0 @@ -import Ember from 'ember'; - -export default Ember.Component.extend({ - actions: { - search: function() { - let strain = this.get('selectedStrain'); - let characteristic = this.get('selectedCharacteristic'); - if ((strain === 'all') && (characteristic === 'all')) { - this.store.findAll('measurement').then((measurements)=>{ - this.set('measurements', measurements); - }); - return; - } - let search = {}; - if (strain !== 'all') { - search['strain'] = strain; - } - if (characteristic !== 'all') { - search['characteristic'] = characteristic; - } - this.store.find('measurement', search).then((measurements)=>{ - this.set('measurements', measurements); - }); - } - }, -}); diff --git a/app/pods/components/measurement-search-table/template.hbs b/app/pods/components/measurement-search-table/template.hbs deleted file mode 100644 index 601ad48..0000000 --- a/app/pods/components/measurement-search-table/template.hbs +++ /dev/null @@ -1,34 +0,0 @@ -
-
- {{search-button isLoading=isLoading action='search'}} -
-
-
-
-

Total matching measurements: {{measurements.length}}

-
-
- -{{#if isLoading}} - {{!-- This doesn't work yet, something is blocking --}} - {{loading-panel}} -{{else}} -
- - - - - - - - - {{#each measurements as |measurement|}} - - - - - - {{/each}} - -
StrainCharacteristicValue
{{{measurement.strain.fullNameMU}}}{{measurement.characteristic.characteristicName}}{{{measurement.value}}}
-{{/if}} diff --git a/app/pods/measurements/controller.js b/app/pods/measurements/controller.js new file mode 100644 index 0000000..8bb7819 --- /dev/null +++ b/app/pods/measurements/controller.js @@ -0,0 +1,15 @@ +import Ember from 'ember'; + +export default Ember.Controller.extend({ + actions: { + search: function() { + let search = { + strain: this.get('selectedStrains'), + characteristic: this.get('selectedCharacteristics'), + }; + this.store.find('measurement', search).then((measurements)=>{ + this.set('measurements', measurements); + }); + } + }, +}); diff --git a/app/pods/measurements/route.js b/app/pods/measurements/route.js index 9c45e22..d460d65 100644 --- a/app/pods/measurements/route.js +++ b/app/pods/measurements/route.js @@ -4,39 +4,28 @@ import AuthenticatedRouteMixin from 'simple-auth/mixins/authenticated-route-mixi export default Ember.Route.extend(AuthenticatedRouteMixin, { model: function() { return Ember.RSVP.hash({ - species: this.store.findAll('species'), + species: this.store.findAll('species'), // need this bc async strains: this.store.findAll('strain'), characteristics: this.store.findAll('characteristic'), }); }, setupController: function(controller, models) { - controller.set('measurements', []); - // Set up search parameters - models.strains = models.strains.sortBy('fullName'); - let strains = models.strains.map((strain)=>{ - return Ember.Object.create({ - id: strain.get('id'), - text: strain.get('fullName'), - }); - }); - strains.unshiftObjects(Ember.Object.create({ - id: 'all', - text: 'All Strains', - })); - controller.set('strains', strains); + let selects = [ + { model: 'strains', id: 'id', text: 'fullName' }, + { model: 'characteristics', id: 'id', text: 'characteristicName' }, + ]; - models.characteristics = models.characteristics.sortBy('characteristicName'); - let characteristics = models.characteristics.map((characteristic)=>{ - return Ember.Object.create({ - id: characteristic.get('id'), - text: characteristic.get('characteristicName'), + selects.forEach((item, index, enumerable) => { + models[item.model] = models[item.model].sortBy(item.text); + let temp = models[item.model].map((data) => { + return Ember.Object.create({ + id: data.get(item.id), + text: data.get(item.text), + }); }); + controller.set(item.model, temp); }); - characteristics.unshiftObjects(Ember.Object.create({ - id: 'all', - text: 'All Characteristics', - })); - controller.set('characteristics', characteristics); + }, }); diff --git a/app/pods/measurements/template.hbs b/app/pods/measurements/template.hbs index 882fce6..fe3922c 100644 --- a/app/pods/measurements/template.hbs +++ b/app/pods/measurements/template.hbs @@ -1,37 +1,61 @@

{{genus-name}} Measurements

-
-
- Strains -
-
- {{ - select-2 - multiple=true - content=strains - value=selectedStrains - optionValuePath="id" - placeholder="Choose a strain" - }} -
-
-
-
- Characteristics -
-
- {{ - select-2 - multiple=true - content=characteristics - value=selectedCharacteristic - optionValuePath="id" - placeholder="Choose a characteristic" - }} +
+
+
+
+
    +
  • + + {{ + select-2 + multiple=true + content=strains + value=selectedStrains + optionValuePath="id" + placeholder="All strains" + }} +
    • +
  • + + {{ + select-2 + multiple=true + content=characteristics + value=selectedCharacteristics + optionValuePath="id" + placeholder="Choose a characteristic" + }} +
    • +
  • + {{search-button isLoading=isLoading action='search'}} +
    • +
+
+
-{{ - measurement-search-table - selectedStrain=selectedStrain - selectedCharacteristic=selectedCharacteristic -}} +
+
+

Total matching measurements: {{measurements.length}}

+
+
+ + + + + + + + + + + {{#each measurements as |measurement|}} + + + + + + {{/each}} + +
StrainCharacteristicValue
{{{measurement.strain.fullNameMU}}}{{measurement.characteristic.characteristicName}}{{{measurement.value}}}
diff --git a/app/styles/app.css b/app/styles/app.css index b5d48ca..ff245dd 100644 --- a/app/styles/app.css +++ b/app/styles/app.css @@ -2,6 +2,10 @@ padding: 2em 0em 0em 0em; } +.select2-container { + width: 100%; +} + .flakes-table thead tr th span { cursor: pointer; } diff --git a/tests/unit/components/display-error-test.js b/tests/unit/components/display-error-test.js deleted file mode 100644 index e81245a..0000000 --- a/tests/unit/components/display-error-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('display-error', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/components/genus-name-test.js b/tests/unit/components/genus-name-test.js deleted file mode 100644 index 8993325..0000000 --- a/tests/unit/components/genus-name-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('genus-name', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/components/measurements/measurement-row-test.js b/tests/unit/components/measurements/measurement-row-test.js deleted file mode 100644 index 1664fcd..0000000 --- a/tests/unit/components/measurements/measurement-row-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('measurements/measurement-row', { - // specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/components/species/species-details-test.js b/tests/unit/components/species/species-details-test.js deleted file mode 100644 index b3c5c67..0000000 --- a/tests/unit/components/species/species-details-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('species/species-details', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/components/strains/strain-details-test.js b/tests/unit/components/strains/strain-details-test.js deleted file mode 100644 index a52c33c..0000000 --- a/tests/unit/components/strains/strain-details-test.js +++ /dev/null @@ -1,21 +0,0 @@ -import { - moduleForComponent, - test -} from 'ember-qunit'; - -moduleForComponent('strains/strain-details', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/pods/components/measurement-index-row/component-test.js b/tests/unit/pods/components/measurement-index-row/component-test.js deleted file mode 100644 index af52af6..0000000 --- a/tests/unit/pods/components/measurement-index-row/component-test.js +++ /dev/null @@ -1,18 +0,0 @@ -import { moduleForComponent, test } from 'ember-qunit'; - -moduleForComponent('measurement-index-row', 'Unit | Component | measurement index row', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'] -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/pods/components/measurement-search-table/component-test.js b/tests/unit/pods/components/measurement-search-table/component-test.js deleted file mode 100644 index 6ec5359..0000000 --- a/tests/unit/pods/components/measurement-search-table/component-test.js +++ /dev/null @@ -1,19 +0,0 @@ -import { moduleForComponent, test } from 'ember-qunit'; - -moduleForComponent('measurement-search-table', 'Unit | Component | measurement search table', { - // Specify the other units that are required for this test - // needs: ['component:foo', 'helper:bar'], - unit: true -}); - -test('it renders', function(assert) { - assert.expect(2); - - // Creates the component instance - var component = this.subject(); - assert.equal(component._state, 'preRender'); - - // Renders the component to the page - this.render(); - assert.equal(component._state, 'inDOM'); -}); diff --git a/tests/unit/pods/measurements/controller-test.js b/tests/unit/pods/measurements/controller-test.js new file mode 100644 index 0000000..f20328f --- /dev/null +++ b/tests/unit/pods/measurements/controller-test.js @@ -0,0 +1,12 @@ +import { moduleFor, test } from 'ember-qunit'; + +moduleFor('controller:measurements', { + // Specify the other units that are required for this test. + // needs: ['controller:foo'] +}); + +// Replace this with your real tests. +test('it exists', function(assert) { + var controller = this.subject(); + assert.ok(controller); +});