thermokarst/planner
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix nil plans bug in Tasks.update_task (#58)

Browse source
This commit is contained in:
Matthew Ryan Dillon 2020-11-21 18:28:25 -07:00 • committed by GitHub
parent cef9ea72c6
commit 404caad2ac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/planner/tasks.ex
View file

@ -74,14 +74,16 @@ defmodule Planner.Tasks do
end end
def update_task(%Task{} = task, attrs) do def update_task(%Task{} = task, attrs) do
new_plan_details_changesets = Enum.map(attrs["plans"], fn(plan_id) -> plans = Map.get(attrs, "plans", [])
new_plan_details_changesets = Enum.map(plans, fn(plan_id) ->
PlanDetail.changeset(%PlanDetail{}, %{"task_id" => task.id, "plan_id" => plan_id}) PlanDetail.changeset(%PlanDetail{}, %{"task_id" => task.id, "plan_id" => plan_id})
end) end)
deleted_plan_details = deleted_plan_details =
Ecto.Query.from( Ecto.Query.from(
pd in PlanDetail, pd in PlanDetail,
where: pd.task_id == ^task.id and pd.plan_id not in ^attrs["plans"] where: pd.task_id == ^task.id and pd.plan_id not in ^plans
) )
multi = multi =