thermokarst/planner
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bug: plan+task query producing multiple results (#68)

Browse source
This commit is contained in:
Matthew Ryan Dillon 2020-12-06 20:03:50 -07:00 • committed by GitHub
parent e0ad13ee6c
commit 7aa0059c96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/planner/tasks.ex
View file

@ -38,7 +38,9 @@ defmodule Planner.Tasks do
t in Task, t in Task,
join: pd in PlanDetail, join: pd in PlanDetail,
on: t.id == pd.task_id, on: t.id == pd.task_id,
where: (pd.plan_id == ^plan_id and is_nil(t.finished_at)) or t.id == ^task_id, where: (pd.plan_id == ^plan_id and is_nil(t.finished_at))
or
(pd.plan_id == ^plan_id and t.id == ^task_id),
order_by: [desc: t.updated_at] order_by: [desc: t.updated_at]
) )

2
lib/planner_web/live/tasks_live.ex
View file

@ -187,7 +187,7 @@ defmodule PlannerWeb.TasksLive do
end end
def handle_event("finish-task", %{"task-id" => task_id}, socket) do def handle_event("finish-task", %{"task-id" => task_id}, socket) do
{_, task} = Tasks.finish_task_by_id!(task_id) {_, _} = Tasks.finish_task_by_id!(task_id)
route = get_index_route(socket) route = get_index_route(socket)
{:noreply, push_patch(socket, to: route)} {:noreply, push_patch(socket, to: route)}
end end